baff1c42ec
Some checks failed
CI / Lint (bash) (push) Has been cancelled
CI / Lint (markdown) (push) Has been cancelled
CI / Lint (nickel) (push) Has been cancelled
CI / Lint (nushell) (push) Has been cancelled
CI / Lint (rust) (push) Has been cancelled
CI / Benchmark (push) Has been cancelled
CI / Security Audit (push) Has been cancelled
CI / License Compliance (push) Has been cancelled
CI / Code Coverage (push) Has been cancelled
CI / Test (macos-latest) (push) Has been cancelled
CI / Test (ubuntu-latest) (push) Has been cancelled
CI / Test (windows-latest) (push) Has been cancelled
CI / Build (macos-latest) (push) Has been cancelled
CI / Build (ubuntu-latest) (push) Has been cancelled
CI / Build (windows-latest) (push) Has been cancelled
Deduplication
- Consolidate three copies of match field.field_type into InquireBackend::execute_field_sync
as single canonical implementation (backends/cli.rs)
- Add previous_results param to execute_field_sync (pub(crate)); propagate options_from
filtering previously absent from the cli.rs copy
- Move filter_options_from to backends/cli.rs pub(crate); remove duplicate copies from
executor.rs and nickel/roundtrip.rs (-346 lines, 0 behavior regressions)
- Gate legacy sync path (execute_with_base_dir, execute, load_and_execute_from_file)
on #[cfg(feature = "cli")]
Retry fix
- Replace unbounded recursive retry in execute_field_sync with loop+continue (O(1) stack)
RenderContext clone cost
- Change RenderContext.results from HashMap<String, Value> to Arc<HashMap<String, Value>>
- Change executor accumulators to Arc in execute_with_backend_complete,
execute_with_backend_tw execute_with_backend_tw execute_with_backend_tw execute_with_backend_tw execute_with_bante execute_won: execute_with_backend_tw execute_with_backend_tw execute_with_backend_tw execute_count==1 (guaranteed at each insert site)
- typedialog-ai/backend.rs: &context.results -> context.results.iter() for Arc deref
Doctests
- Fix five broken doctests: FormDefinition fields renamed, confirm() arity, FormBackend
methods replaced, cli_loader ignore -> no_run with concr methods replaced, cli_loader ignore -> no_run with concr methods reken methods replaced, cli_loader ignore -> no_run with concr methods replaced, clsync path
- docs/architecture.md Known Technical Debt: all items resolved, section closed
EOF