jesus/be-technical-interview-rust
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: fix CHANGES.md

Browse Source
This commit is contained in:
Jesús Pérez 2024-10-17 16:00:02 +01:00
parent caf553e4d5
commit 30c705dcde
No known key found for this signature in database
1 changed files with 1 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
CHANGES.md
View File

@ -1,22 +1,5 @@
# Backend internal interview (rust)
## CHANGES: fixed branch
## CHANGES: improved branch
- Moving from **HashMap** to **BTreeMap** to preseve loading lines order.
- Fix **lines parser** in Maps **metrics** and in **aggregated_metrics** to be handled properly.
- Fix **unwrap / expect** for obvious reasons, add simple error message via **map_err**, **unwrap_or_else** and **closure function**.
- Fix some source code lines order, output format and conversions.
- Change some **iterators** to <u>functional mode</u>.
- Separate tasks to independent funtions for better isolation, less responsibilities and help on **tests** handling.
- Adding **output_path** to help on result output options.
- Following **unit tests** are implemented:
- <u>test_load_input</u> test load input file **input.txt**.
- <u>test_invalid_line_value</u> test use invalid value in line parsing.
- <u>test_invalid_line</u> test use invlid value in line parsing.
- <u>test_expected_metrics</u> test load input data from **input.txt** compare with **output_expected.txt**.
> Code simply **works as expected**
> It is not be able to **process multiple metrics in parallel** yet.
> A full refactoring has to be done for <u>better quality, maintenance and be more readable</u>. (Structs, implementaitions, settings for multiple inputs, etc).
Next round in: [Improve branch](/NewRelic/be-technical-interview-rust/src/branch/improved)