From 6d0ba2ac14a796d43cd40b24bbca178114b9d457 Mon Sep 17 00:00:00 2001
From: cobyfrombrooklyn-bot <cobyfrombrooklyn@gmail.com>
Date: Sun, 22 Feb 2026 20:44:05 -0500
Subject: [PATCH] Fix nested admonitions using wrong header color

Use child combinator (>) instead of descendant selector for
blockquote-tag-title color rules. Without this, a nested admonition
inherits the title color of its parent admonition instead of using
its own type's color.

Added nested admonition test case (important > note) to the existing
admonition test suite.

Fixes #3032
---
 crates/mdbook-html/front-end/css/general.css           | 10 +++++-----
 .../markdown/admonitions/expected/admonitions.html     |  8 ++++++++
 .../admonitions/expected_disabled/admonitions.html     |  8 ++++++++
 .../testsuite/markdown/admonitions/src/admonitions.md  |  6 ++++++
 4 files changed, 27 insertions(+), 5 deletions(-)

diff --git a/crates/mdbook-html/front-end/css/general.css b/crates/mdbook-html/front-end/css/general.css
index df8a3efe..91401e3b 100644
--- a/crates/mdbook-html/front-end/css/general.css
+++ b/crates/mdbook-html/front-end/css/general.css
@@ -371,23 +371,23 @@ dd > p {
     border-inline-start-color: var(--blockquote-caution-color);
 }
 
-.blockquote-tag-note .blockquote-tag-title {
+.blockquote-tag-note > .blockquote-tag-title {
     color: var(--blockquote-note-color);
 }
 
-.blockquote-tag-tip .blockquote-tag-title {
+.blockquote-tag-tip > .blockquote-tag-title {
     color: var(--blockquote-tip-color);
 }
 
-.blockquote-tag-important .blockquote-tag-title {
+.blockquote-tag-important > .blockquote-tag-title {
     color: var(--blockquote-important-color);
 }
 
-.blockquote-tag-warning .blockquote-tag-title {
+.blockquote-tag-warning > .blockquote-tag-title {
     color: var(--blockquote-warning-color);
 }
 
-.blockquote-tag-caution .blockquote-tag-title {
+.blockquote-tag-caution > .blockquote-tag-title {
     color: var(--blockquote-caution-color);
 }
 
diff --git a/tests/testsuite/markdown/admonitions/expected/admonitions.html b/tests/testsuite/markdown/admonitions/expected/admonitions.html
index 8bbf4c87..962e7d79 100644
--- a/tests/testsuite/markdown/admonitions/expected/admonitions.html
+++ b/tests/testsuite/markdown/admonitions/expected/admonitions.html
@@ -23,4 +23,12 @@
 <blockquote>
 <p>[!UNKNOWN]
 This is an unknown tag.</p>
+</blockquote>
+<blockquote class="blockquote-tag blockquote-tag-important">
+<p class="blockquote-tag-title"><svg viewbox="0 0 16 16" width="18" height="18"><path d="M0 1.75C0 .784.784 0 1.75 0h12.5C15.216 0 16 .784 16 1.75v9.5A1.75 1.75 0 0 1 14.25 13H8.06l-2.573 2.573A1.458 1.458 0 0 1 3 14.543V13H1.75A1.75 1.75 0 0 1 0 11.25Zm1.75-.25a.25.25 0 0 0-.25.25v9.5c0 .138.112.25.25.25h2a.75.75 0 0 1 .75.75v2.19l2.72-2.72a.749.749 0 0 1 .53-.22h6.5a.25.25 0 0 0 .25-.25v-9.5a.25.25 0 0 0-.25-.25Zm7 2.25v2.5a.75.75 0 0 1-1.5 0v-2.5a.75.75 0 0 1 1.5 0ZM9 9a1 1 0 1 1-2 0 1 1 0 0 1 2 0Z"></path></svg>Important</p>
+<p>This is an important admonition.</p>
+<blockquote class="blockquote-tag blockquote-tag-note">
+<p class="blockquote-tag-title"><svg viewbox="0 0 16 16" width="18" height="18"><path d="M0 8a8 8 0 1 1 16 0A8 8 0 0 1 0 8Zm8-6.5a6.5 6.5 0 1 0 0 13 6.5 6.5 0 0 0 0-13ZM6.5 7.75A.75.75 0 0 1 7.25 7h1a.75.75 0 0 1 .75.75v2.75h.25a.75.75 0 0 1 0 1.5h-2a.75.75 0 0 1 0-1.5h.25v-2h-.25a.75.75 0 0 1-.75-.75ZM8 6a1 1 0 1 1 0-2 1 1 0 0 1 0 2Z"></path></svg>Note</p>
+<p>This nested note should have its own color.</p>
+</blockquote>
 </blockquote>
\ No newline at end of file
diff --git a/tests/testsuite/markdown/admonitions/expected_disabled/admonitions.html b/tests/testsuite/markdown/admonitions/expected_disabled/admonitions.html
index 3bb296ed..65c10471 100644
--- a/tests/testsuite/markdown/admonitions/expected_disabled/admonitions.html
+++ b/tests/testsuite/markdown/admonitions/expected_disabled/admonitions.html
@@ -23,4 +23,12 @@ This is a caution.</p>
 <blockquote>
 <p>[!UNKNOWN]
 This is an unknown tag.</p>
+</blockquote>
+<blockquote>
+<p>[!IMPORTANT]
+This is an important admonition.</p>
+<blockquote>
+<p>[!NOTE]
+This nested note should have its own color.</p>
+</blockquote>
 </blockquote>
\ No newline at end of file
diff --git a/tests/testsuite/markdown/admonitions/src/admonitions.md b/tests/testsuite/markdown/admonitions/src/admonitions.md
index 0bf6526f..bb5102ac 100644
--- a/tests/testsuite/markdown/admonitions/src/admonitions.md
+++ b/tests/testsuite/markdown/admonitions/src/admonitions.md
@@ -19,3 +19,9 @@
 
 > [!UNKNOWN]
 > This is an unknown tag.
+
+> [!IMPORTANT]
+> This is an important admonition.
+>
+> > [!NOTE]
+> > This nested note should have its own color.