From f54356da1067d39a041c92516ee0b17d4a8702cd Mon Sep 17 00:00:00 2001
From: Guillaume Gomez <guillaume1.gomez@gmail.com>
Date: Sat, 22 Mar 2025 17:51:07 +0100
Subject: [PATCH] Remove `fail-on-request-error` in GUI tests as they are not
 needed anymore

---
 tests/gui/move-between-pages.goml | 3 +--
 tests/gui/search.goml             | 3 ---
 tests/gui/sidebar-nojs.goml       | 3 ---
 tests/gui/sidebar.goml            | 3 ---
 4 files changed, 1 insertion(+), 11 deletions(-)

diff --git a/tests/gui/move-between-pages.goml b/tests/gui/move-between-pages.goml
index 9177b364..2c707300 100644
--- a/tests/gui/move-between-pages.goml
+++ b/tests/gui/move-between-pages.goml
@@ -1,7 +1,6 @@
 // This tests pressing the left and right arrows moving to previous and next page.
 
-// We disable the requests checks because `searchindex.json` will always fail
-// locally (due to CORS), but the searchindex.js will succeed.
+// We disable the requests checks because `mode-rust.js` is not found.
 fail-on-request-error: false
 
 go-to: |DOC_PATH| + "index.html"
diff --git a/tests/gui/search.goml b/tests/gui/search.goml
index dd386d0d..dd362bd1 100644
--- a/tests/gui/search.goml
+++ b/tests/gui/search.goml
@@ -1,8 +1,5 @@
 // This tests basic search behavior.
 
-// We disable the requests checks because `searchindex.json` will always fail
-// locally (due to CORS), but the searchindex.js will succeed.
-fail-on-request-error: false
 go-to: |DOC_PATH| + "index.html"
 
 define-function: (
diff --git a/tests/gui/sidebar-nojs.goml b/tests/gui/sidebar-nojs.goml
index 9a8622f9..05bbd65a 100644
--- a/tests/gui/sidebar-nojs.goml
+++ b/tests/gui/sidebar-nojs.goml
@@ -2,9 +2,6 @@
 // an iframe (because of JS disabled).
 // Regression test for <https://github.com/rust-lang/mdBook/issues/2528>.
 
-// We disable the requests checks because `searchindex.json` will always fail
-// locally.
-fail-on-request-error: false
 // We disable javascript
 javascript: false
 go-to: |DOC_PATH| + "index.html"
diff --git a/tests/gui/sidebar.goml b/tests/gui/sidebar.goml
index 7e4ec32b..61dded10 100644
--- a/tests/gui/sidebar.goml
+++ b/tests/gui/sidebar.goml
@@ -1,9 +1,6 @@
 // This GUI test checks sidebar hide/show and also its behaviour on smaller
 // width.
 
-// We disable the requests checks because `searchindex.json` will always fail
-// locally.
-fail-on-request-error: false
 go-to: |DOC_PATH| + "index.html"
 set-window-size: (1100, 600)
 // Need to reload for the new size to be taken account by the JS.