Eric Huss
1476ec72c3
Merge pull request #2725 from GuillaumeGomez/search-collapsed
...
Hide the sidebar when collapsed to prevent browser search to find text from it
2025-07-07 17:03:13 +00:00
Eric Huss
d1c09791ab
Fix animation bug in safari
...
When showing the sidebar, Safari was causing the sidebar to snap into
place without animating. This is apparently some well-known issue where
it doesn't like adding new elements (or changing display) and toggling
an animated transition in the same event loop.
2025-07-07 09:47:55 -07:00
Guillaume Gomez
16b99be17f
Update sidebar GUI test
2025-07-07 09:47:55 -07:00
Guillaume Gomez
bcd4552bdf
Hide the sidebar when collapsed to prevent browser search to find text from it
2025-07-07 09:47:33 -07:00
Guillaume Gomez
f942f3835e
Remove unused CSS class sidebar-hidden
2025-07-07 09:47:33 -07:00
Michael Howell
e96c608c11
Remove direct search index reference from searcher
...
Because `{{resource}}` references don't affect the hash[^1], we need
to avoid referencing dynamic content from within static content.
Otherwise, you get a cached searcher.js referencing a searchindex
that no longer exists.
[^1]: if we made it affect the hash, we'd have to do full dependency
tracking, and we'd no longer be able to support circular refs
2025-07-07 09:08:06 -07:00
Eric Huss
e6315bf2b1
Merge pull request #2738 from szabgab/test/test-tokenize
...
add tests to the tokenize() function
2025-06-30 15:01:44 +00:00
Gabor Szabo
6d63343b46
add tests to the tokenize() function
2025-06-30 16:11:35 +03:00
Eric Huss
e1e4518499
Merge pull request #2736 from GuillaumeGomez/update-browser-ui-test
...
Update browser-ui-test version to `0.21.0`
2025-06-28 20:34:15 +00:00
Guillaume Gomez
34d68403da
Update browser-ui-test version to 0.21.0
2025-06-28 13:28:20 -07:00
Eric Huss
e395341210
Merge pull request #2735 from GuillaumeGomez/fix-js-error
...
Fix JS error when `hasFocus` method is overwritten on search index load
2025-06-28 19:55:37 +00:00
Guillaume Gomez
f4c54178c8
Update tests
2025-06-28 00:04:02 +02:00
Guillaume Gomez
63e1dac122
Fix JS error when hasFocus method is overwritten on search index load
2025-06-25 18:24:33 +02:00
Eric Huss
e8dff6f97e
Merge pull request #2726 from Sableoxide/fix-typo-isnt-it
...
Fix typo 'isn't is?' -> 'isn't it?' in test_book/src/individual/code.md
2025-06-09 15:21:24 +00:00
frank goko
534666f551
fixed typo 'isn't is?' -> 'isn't it?' in test_book/src/individual/code.md
2025-06-08 23:42:42 +03:00
Eric Huss
f3ee794283
Merge pull request #2715 from tshepang/patch-1
...
add another link type
2025-06-02 15:14:02 +00:00
Eric Huss
94f9a9c5e0
Merge pull request #2553 from GuillaumeGomez/load-on-need
...
Only load searchindex when needed
2025-06-02 15:01:09 +00:00
Guillaume Gomez
dc6b0a6e58
Update search test
2025-05-31 09:55:58 +02:00
Guillaume Gomez
2fa13cf4e0
Add a spinner when search is in progress
2025-05-31 09:36:27 +02:00
Guillaume Gomez
d64a863223
Add GUI test for search
2025-05-31 09:36:27 +02:00
Guillaume Gomez
1fb91d67f6
Only load searchindex when needed
2025-05-31 09:36:27 +02:00
Eric Huss
1b046e5a90
Merge pull request #2719 from ehuss/update-browser-ui-test
...
Update browser-ui-test to 0.20.6
2025-05-30 19:39:59 +00:00
Eric Huss
e9f5e3d7c0
Update browser-ui-test to 0.20.6
...
This updates browser-ui-test to 0.20.6 which has some new features
that could be useful.
2025-05-30 12:23:27 -07:00
Tshepang Mbambo
c6a5d05c64
add another link type
2025-05-30 21:18:11 +02:00
Eric Huss
f93b2675ff
Merge pull request #2714 from ehuss/bump-version
...
Update to 0.4.51
2025-05-26 18:23:28 +00:00
Eric Huss
365918bf89
Merge pull request #2713 from ehuss/fix-s-key
...
Fix search hotkey
2025-05-26 18:04:46 +00:00
Eric Huss
76be253f76
Update to 0.4.51
2025-05-26 11:01:12 -07:00
Eric Huss
0210e69abc
Fix search hotkey
...
https://github.com/rust-lang/mdBook/pull/2608 accidentally broke the
search "S" keybinding by using the wrong capitalization.
2025-05-26 10:58:53 -07:00
Eric Huss
cdbf6d2806
Merge pull request #2712 from ehuss/bump-version
...
Update to 0.4.50
2025-05-23 15:04:07 +00:00
Eric Huss
902ded9f89
Merge pull request #2711 from ehuss/update-dependencies
...
Update dependencies
2025-05-23 15:01:40 +00:00
Eric Huss
851932bd4b
Update to 0.4.50
2025-05-23 07:57:51 -07:00
Eric Huss
f38dc687e3
Update dependencies
...
Also bump MSRV to 1.82
Updating anstyle-wincon v3.0.7 -> v3.0.8
Updating backtrace v0.3.74 -> v0.3.75
Updating bitflags v2.9.0 -> v2.9.1
Updating cc v1.2.21 -> v1.2.24
Updating clap v4.5.37 -> v4.5.38
Updating clap_builder v4.5.37 -> v4.5.38
Updating clap_complete v4.5.48 -> v4.5.50
Updating errno v0.3.11 -> v0.3.12
Updating getrandom v0.3.2 -> v0.3.3
Updating icu_collections v1.5.0 -> v2.0.0
Adding icu_locale_core v2.0.0
Removing icu_locid v1.5.0
Removing icu_locid_transform v1.5.0
Removing icu_locid_transform_data v1.5.1
Updating icu_normalizer v1.5.0 -> v2.0.0
Updating icu_normalizer_data v1.5.1 -> v2.0.0
Updating icu_properties v1.5.1 -> v2.0.1
Updating icu_properties_data v1.5.1 -> v2.0.1
Updating icu_provider v1.5.0 -> v2.0.0
Removing icu_provider_macros v1.5.0
Updating idna_adapter v1.2.0 -> v1.2.1
Updating jiff v0.2.12 -> v0.2.14
Updating jiff-static v0.2.12 -> v0.2.14
Updating kqueue v1.0.8 -> v1.1.1
Updating litemap v0.7.5 -> v0.8.0
Adding once_cell_polyfill v1.70.1
Adding potential_utf v0.1.2
Updating rustversion v1.0.20 -> v1.0.21
Updating tempfile v3.19.1 -> v3.20.0
Updating tinystr v0.7.6 -> v0.8.1
Updating tokio v1.44.2 -> v1.45.0
Removing utf16_iter v1.0.5
Updating web_atoms v0.1.1 -> v0.1.2
Updating windows-core v0.61.0 -> v0.61.2
Updating windows-result v0.3.2 -> v0.3.4
Updating windows-strings v0.4.0 -> v0.4.2
Removing write16 v1.0.0
Updating writeable v0.5.5 -> v0.6.1
Updating yoke v0.7.5 -> v0.8.0
Updating yoke-derive v0.7.5 -> v0.8.0
Adding zerotrie v0.2.2
Updating zerovec v0.10.4 -> v0.11.2
Updating zerovec-derive v0.10.3 -> v0.11.1
2025-05-23 07:55:10 -07:00
Eric Huss
391ee3bae2
Merge pull request #2695 from hamirmahal/fix/invalid-heading-order-in-contributing-md
...
fix: invalid heading order in `CONTRIBUTING.md`
2025-05-23 14:53:01 +00:00
Hamir Mahal
ad3096e871
fix: invalid heading order in CONTRIBUTING.md
2025-05-23 07:46:40 -07:00
Eric Huss
179bd8dcd5
Merge pull request #2710 from ehuss/fix-mode-rust
...
Fix loading of mode-rust.js
2025-05-23 14:42:05 +00:00
Eric Huss
426e7bee17
Fix loading of mode-rust.js
...
The reason the ACE editor was failing to load the rust syntax
highlighting is because the syntax highlighting was being created
*after* the editor was created. If the editor is created first, then ACE
tries to load `ace/mode/rust`. Since it isn't already defined, it tried
to compute the URL and load it manually. However, since the URLs now
have a hash in it (via https://github.com/rust-lang/mdBook/pull/1368 ),
it was unable to load.
The solution here is to make sure `ace/mode/rust` is defined before
creating the editors. Then ACE knows that it can just load the module
directly instead of trying to fetch it from the server.
Fixes https://github.com/rust-lang/mdBook/issues/2700
2025-05-23 07:19:27 -07:00
Eric Huss
564c80bf6d
Merge pull request #2709 from zeenix/master
...
Update `opener` to 0.8.1
2025-05-21 20:22:49 +00:00
Zeeshan Ali Khan
363c12e9c3
Update opener to 0.8.1
...
This removes a few indirect deps, especially system deps like `dbus` and
`pkg-config`.
2025-05-21 18:33:43 +02:00
Eric Huss
1ffa9fe830
Merge pull request #2707 from noritada/fix/edition2024-in-guide
...
Document the `edition2024` code block attribute
2025-05-19 15:38:52 +00:00
Noritada Kobayashi
91d13c390a
Document the edition2024 code block attribute
2025-05-19 12:51:11 +09:00
Eric Huss
ce8d8120f8
Merge pull request #2705 from ehuss/help-test
...
Add help gui test
2025-05-15 12:32:27 +00:00
Eric Huss
038b5fb232
Add help gui test
2025-05-15 05:25:48 -07:00
Eric Huss
fd768efba2
Merge pull request #2703 from ehuss/fix-clippy
...
Fix clippy lint for 1.88
2025-05-15 01:27:40 +00:00
Eric Huss
481346812c
Merge pull request #2608 from szabgab/navigation-help
...
Add pop-up window showing the keyboard shortcuts
2025-05-15 01:24:55 +00:00
Eric Huss
3d07798832
Fix clippy lint for 1.88
2025-05-14 18:18:45 -07:00
Eric Huss
33da0c26c4
Some updates to the help popup
...
This makes a few changes to the help popup:
- Move css to chrome.css, since this is a UI element.
- Move HTML code to index.hbs instead of generated in JavaScript.
In general I prefer to keep HTML out of JavaScript when possible,
and I didn't see a particular reason to avoid it.
- Added a click handler to dismiss the popup.
- Make sure handlers get removed when dismissed.
- Use `mdbook-` prefixes for IDs to avoid collisions with headers.
- Don't show search if it isn't enabled.
- Add the new `/` shortcut.
- Use flex layout for better positioning.
- Dim out the surrounding text using an overlay.
- Various other styling tweaks.
- Add a GUI test.
2025-05-14 18:17:16 -07:00
Eric Huss
91e94024cd
Switch searcher to use keys instead of keyCodes
...
According to
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode
the keyCode is deprecated (and removed). It is causing me some
difficulty with the GUI tests because it can't differentiate between a
slash and question mark correctly. Using keys seems to work.
2025-05-14 18:16:20 -07:00
Gabor Szabo
c9ad6dbf10
eslint
2025-05-14 17:06:49 -07:00
Gabor Szabo
2b455fcd34
Make the help visible in all the themes of mdbook
...
Also handle the ? key with or without shift being pressed.
2025-05-14 17:06:49 -07:00
Gabor Szabo
4573f4d882
Add pop-up window showing the keyboard shortcuts
...
Make it display when the user presses `?`.
Implements #2607
2025-05-14 17:06:49 -07:00