nushell-plugins/scripts/update_all_plugins.nu
Jesús Pérez 2b3e574e3d # Summary
fix: help system integration, build process optimization, and plugin rebuild efficiency

## Detailed Description

This commit addresses critical issues in the help system discoverability, build process robustness, and plugin rebuild efficiency.

### 1. Help System Integration (New Feature)

**Issue**: Version-update module recipes were not discoverable
- Not shown in `just help modules`
- Not referenced in `just help`
- Not included in help navigation system
- Users had to manually run `just --list` to find update commands

**Solution**:
- Added version-update module to all help outputs
- Updated `justfiles/help.just` to document all 30+ version-update recipes
- Created new `just commands` recipe as discoverable alias for `just --list`
- Integrated version-update into help-all workflow

**Impact**:
- Version-update commands now fully discoverable via help system
- Users can find update commands with: `just help modules`, `just help`, `just commands`
- Improved overall help system navigation

**Files Modified**:
- `justfiles/help.just` (+23 lines)
  - Added version-update module to help sections
  - Added to modules list
  - Added to help-all workflow
  - New `commands` recipe showing all recipes by group

### 2. Build Process Fixes (Phase 3: Bin Archives)

#### 2a. Plugin Archive Collection Bug

**Issue**: "No plugins found to package" warning in Phase 3
- Collected 26 plugin binaries but reported 0
- Archive creation skipped because count was wrong

**Root Cause**: `each` command returns null, so `| length` returned 0
```nushell
#  OLD - each returns null
let plugin_count = (ls nu_plugin_*/target/release/nu_plugin_* | each {|p|
    cp $p.name $"($temp_dir)/"
} | length)  # Returns 0!
```

**Solution**: Separated counting from copying with proper filtering
```nushell
#  NEW - count before operations
let plugins_to_copy = (ls nu_plugin_*/target/release/nu_plugin_* | where type == "file")
let plugin_count = ($plugins_to_copy | length)
```

**Impact**:
- Now correctly collects and reports 26 plugins
- Filters out .d dependency files automatically
- Warning eliminated

#### 2b. Tar Archive Path Handling

**Issue**: Tar command failing silently with relative paths in subshell
- `cd $temp_dir` changes context unpredictably
- Relative path `../$archive_name` fails in subshell
- Archive file not created despite exit code 0

**Root Cause**: Shell context and relative path issues in Nushell `do` block

**Solution**: Used `tar -C` with absolute paths instead of `cd`
```nushell
#  OLD - unreliable context switching
do {
    cd $temp_dir
    tar -czf ../$archive_name .
}

#  NEW - absolute paths, no context switching
tar -C $temp_dir -czf $archive_path .
```

**Additional Improvements**:
- Absolute path construction using `pwd | path join`
- Better error diagnostics with exit code and stderr output
- File verification after creation

**Impact**:
- Tar archives now created successfully
- Robust path handling across platforms
- Clear error messages for debugging

#### 2c. File Size Calculation Type Error

**Issue**: Runtime error when calculating archive size
```
Error: The '/' operator does not work on values of type 'list<filesize>'
```

**Root Cause**: `ls` returns list of records, so `.size` was a list
```nushell
#  OLD - returns list<filesize>
(ls $archive_path).size / 1024 / 1024

#  NEW - returns filesize
(ls $archive_path | get 0.size) / 1024 / 1024
```

**Impact**:
- Proper file size calculation in MB
- No more type errors

**Files Modified**:
- `scripts/create_full_distribution.nu` (+58 lines, refactored plugin collection)
  - Fixed plugin counting logic
  - Improved path handling with absolute paths
  - Enhanced error diagnostics

### 3. Plugin Rebuild Optimization

**Issue**: All plugins marked for rebuild even when dependencies unchanged
- Step 4 (`update_all_plugins.nu`) touched all Cargo.toml files at 01:00:32
- Step 5 saw all files as "newer" than binaries
- Marked ALL plugins for rebuild, though cargo only rebuilt changed ones

**Root Cause**: Script always saved files, even when no changes made
```nushell
#  OLD - always saves, touching file timestamp
$updated_content | to toml | save -f $cargo_toml
```

**Solution**: Only save if content actually changed
```nushell
#  NEW - compare before writing
let original_toml = $content | to toml
let new_toml = $updated_content | to toml

if $original_toml != $new_toml {
    $updated_content | to toml | save -f $cargo_toml
}
```

**Impact**:
- Unchanged files preserve original timestamps
- Only plugins with actual dependency changes are rebuilt
- Efficient rebuild process with accurate file modification detection

**Files Modified**:
- `scripts/update_all_plugins.nu` (+12 lines, added content comparison)
  - Only touches files with real changes
  - Preserves timestamps for efficiency
  - Clearer logic and comments

### 4. Documentation

**Files Modified**:
- `CHANGELOG.md` (+56 lines)
  - Added comprehensive 2025-10-19 entry
  - Documented all fixes with root causes
  - Listed files modified and impact summary

## Technical Details

### Nushell Patterns Used

1. **Proper List Handling**:
   - `ls` returns list of records, access with `| get 0.size`
   - Filter with `where type == "file"` to exclude metadata

2. **Absolute Path Construction**:
   - `pwd | append "path" | path join` for cross-platform paths
   - Safer than string concatenation with `/`

3. **Content Comparison**:
   - Compare TOML string representation before saving
   - Preserves file timestamps for efficiency

4. **Error Diagnostics**:
   - Capture `stderr` from commands
   - Report exit codes and error messages separately

## Testing

- [x] Help system shows version-update module
- [x] `just commands` displays all recipes by group
- [x] Phase 3 bin archive creation works
- [x] Plugin collection reports correct count (26)
- [x] Tar archives created successfully
- [x] File size calculated correctly
- [x] Plugin rebuild only touches changed files
- [x] CHANGELOG updated with all changes

## Files Changed

```
38 files changed, 2721 insertions(+), 2548 deletions(-)

Core Changes:
- justfiles/help.just                  (+23)  Help system integration
- scripts/create_full_distribution.nu  (+58)  Build process fixes
- scripts/update_all_plugins.nu        (+12)  Rebuild optimization
- CHANGELOG.md                         (+56)  Documentation

Dependency Updates:
- All plugin Cargo.toml and Cargo.lock files (version consistency)
```

## Breaking Changes

None. These are bug fixes and optimizations that maintain backward compatibility.

## Migration Notes

No migration needed. Improvements are transparent to users.

## Related Issues

- Help system discoverability
- Build process Phase 3 failures
- Unnecessary plugin rebuilds
- Build process reliability

## Checklist

- [x] Changes follow Rust/Nushell idioms
- [x] Code is well-commented
- [x] Error handling is comprehensive
- [x] Documentation is updated
- [x] All changes tested
- [x] No breaking changes introduced
2025-10-19 01:17:13 +01:00

325 lines
8.8 KiB
Plaintext
Executable File

#!/usr/bin/env nu
# Update All Plugins - Bulk Plugin Updater
# Updates all nu_plugin_* Cargo.toml dependencies to a new Nushell version
#
# Usage:
# update_all_plugins.nu 0.108.0 # Update to specific version
# update_all_plugins.nu 0.108.0 --auto-approve # Skip confirmation
# update_all_plugins.nu --list # List current versions
use lib/common_lib.nu *
# Main entry point
def main [
target_version?: string # Target Nushell version (e.g., "0.108.0")
--auto-approve # Skip confirmation prompts
--dry-run # Show what would be updated without changing
--list # List current plugin versions
--plugin: string # Update only specific plugin
] {
if $list {
list_plugin_versions
return
}
if ($target_version | is-empty) {
log_error "Please specify a target version"
show_usage
exit 1
}
log_info $"🔄 Updating all plugins to Nushell ($target_version)"
# Get all plugin directories
let plugins = if ($plugin | is-not-empty) {
[{ name: $plugin, path: $plugin }]
} else {
get_plugin_directories
}
if ($plugins | length) == 0 {
log_error "No plugin directories found"
exit 1
}
log_info $"Found ($plugins | length) plugins to update"
# Show current versions
log_info "\n📋 Current Versions:"
for p in $plugins {
let current = get_plugin_version $p.path
print $" ($p.name): ($current)"
}
# Confirm update
if not $auto_approve and not $dry_run {
print ""
let response = input $"Update all plugins to ($target_version)? \(yes/no\): "
if $response != "yes" {
log_info "Update cancelled"
exit 0
}
}
# Update each plugin
mut updated = 0
mut failed = []
print ""
for p in $plugins {
if $dry_run {
log_info $"(DRY RUN) Would update ($p.name)"
$updated = $updated + 1
} else {
let result = update_plugin $p.path $target_version
if $result {
log_success $"✓ Updated ($p.name)"
$updated = $updated + 1
} else {
log_error $"✗ Failed to update ($p.name)"
$failed = ($failed | append $p.name)
}
}
}
# Summary
print ""
if ($failed | length) == 0 {
log_success $"✅ Successfully updated ($updated) plugins to ($target_version)"
} else {
log_warn $"⚠️ Updated ($updated) plugins, ($failed | length) failed:"
for f in $failed {
log_error $" • ($f)"
}
exit 1
}
if not $dry_run {
log_info "\n📝 Next steps:"
log_info " 1. Build plugins: just build"
log_info " 2. Test plugins: just test"
log_info " 3. Create distribution: just pack-full"
}
}
# Show usage
def show_usage [] {
print "Usage:"
print " update_all_plugins.nu <version> # Update to version"
print " update_all_plugins.nu <version> --auto-approve"
print " update_all_plugins.nu --list # List current versions"
print ""
print "Examples:"
print " update_all_plugins.nu 0.108.0"
print " update_all_plugins.nu 0.108.0 --dry-run"
print " update_all_plugins.nu 0.108.0 --plugin nu_plugin_image"
}
# Get plugin directories
def get_plugin_directories []: nothing -> list<record> {
ls nu_plugin_*
| where type == dir
| each {|row|
{
name: (get_plugin_name $row.name)
path: $row.name
}
}
}
# Get plugin name from directory
def get_plugin_name [dir: string]: nothing -> string {
$dir | path basename
}
# Get current plugin version
def get_plugin_version [plugin_dir: string]: nothing -> string {
let cargo_toml = $"($plugin_dir)/Cargo.toml"
if not ($cargo_toml | path exists) {
return "N/A"
}
try {
let cargo_data = open $cargo_toml
let deps = $cargo_data | get dependencies
# Try to get nu-plugin version
if "nu-plugin" in ($deps | columns) {
let nu_plugin_spec = $deps | get nu-plugin
if ($nu_plugin_spec | describe) == "record" {
return ($nu_plugin_spec | get version)
} else {
return $nu_plugin_spec
}
}
return "unknown"
} catch {
return "error"
}
}
# Update single plugin
def update_plugin [
plugin_dir: string
target_version: string
]: nothing -> bool {
let cargo_toml = $"($plugin_dir)/Cargo.toml"
if not ($cargo_toml | path exists) {
log_error $"Cargo.toml not found in ($plugin_dir)"
return false
}
try {
# Read current Cargo.toml
let content = open $cargo_toml
# Update nu-* dependencies
let updated_deps = update_nu_dependencies ($content | get dependencies) $target_version
# Create updated content
let updated_content = $content | update dependencies $updated_deps
# Only save if content actually changed (avoid unnecessary file timestamp updates)
let original_toml = $content | to toml
let new_toml = $updated_content | to toml
if $original_toml != $new_toml {
# Content changed - save the file
$updated_content | to toml | save -f $cargo_toml
return true
} else {
# No changes needed - don't touch the file
return true
}
} catch {|err|
log_error $"Error updating ($plugin_dir): ($err.msg)"
return false
}
}
# Update nu-* dependencies in dependencies table
def update_nu_dependencies [
deps: record
target_version: string
]: nothing -> record {
mut updated_deps = $deps
# List of nu-* crates to update
let nu_crates = [
"nu-plugin"
"nu-protocol"
"nu-engine"
"nu-parser"
"nu-cmd-base"
"nu-color-config"
"nu-utils"
"nu-path"
"nu-glob"
"nu-json"
"nu-pretty-hex"
"nu-system"
"nu-table"
"nu-term-grid"
]
for crate in $nu_crates {
if $crate in ($deps | columns) {
let spec = $deps | get $crate
# Update version based on spec type
if ($spec | describe) == "record" {
# It's a detailed spec with version, path, features, etc.
let updated_spec = $spec | update version $target_version
$updated_deps = ($updated_deps | update $crate $updated_spec)
} else {
# It's just a version string
$updated_deps = ($updated_deps | update $crate $target_version)
}
}
}
$updated_deps
}
# List all plugin versions
def list_plugin_versions [] {
log_info "📋 Current Plugin Versions\n"
let plugins = get_plugin_directories
# Create table of versions
let versions = $plugins | each {|p|
{
plugin: $p.name
nu_plugin_version: (get_plugin_version $p.path)
}
}
$versions | table
print ""
log_info $"Total plugins: ($plugins | length)"
}
# Check for version mismatches
def "main check" [] {
log_info "🔍 Checking for version mismatches\n"
let plugins = get_plugin_directories
# Get all unique versions
let versions = $plugins
| each {|p| get_plugin_version $p.path}
| uniq
if ($versions | length) == 1 {
log_success $"✅ All plugins use consistent version: ($versions | first)"
} else {
log_warn $"⚠️ Version mismatch detected! Found ($versions | length) different versions:"
for v in $versions {
let count = $plugins | each {|p| get_plugin_version $p.path} | where {|ver| $ver == $v} | length
log_info $" ($v): ($count) plugins"
}
# Show which plugins have which versions
print "\nDetailed breakdown:"
for p in $plugins {
let version = get_plugin_version $p.path
print $" ($p.name): ($version)"
}
}
}
# Update to match nushell submodule version
def "main sync" [] {
log_info "🔄 Syncing plugin versions with nushell submodule\n"
# Get version from nushell submodule
let nushell_cargo = "./nushell/Cargo.toml"
if not ($nushell_cargo | path exists) {
log_error "Nushell submodule not found at ./nushell/"
log_info "Download it first with: ./scripts/download_nushell.nu"
exit 1
}
let nushell_version = try {
open $nushell_cargo | get package.version
} catch {
log_error "Failed to read nushell version"
exit 1
}
log_info $"Nushell submodule version: ($nushell_version)"
log_info "Updating all plugins to match...\n"
# Run main update
main $nushell_version --auto-approve
}