ontoref/.pre-commit-config.yaml

160 lines
5.6 KiB
YAML
Raw Normal View History

2026-03-12 23:59:21 +00:00
# Pre-commit Framework Configuration
# Generated by dev-system/ci
# Configures git pre-commit hooks for Rust projects
repos:
# ============================================================================
# Rust Hooks
# ============================================================================
- repo: local
hooks:
- id: rust-fmt
name: Rust formatting (cargo +nightly fmt)
entry: bash -c 'cargo +nightly fmt --all -- --check'
language: system
types: [rust]
pass_filenames: false
stages: [pre-commit]
- id: rust-clippy
name: Rust linting (cargo clippy)
entry: bash -c 'CARGO_TARGET_DIR=target cargo clippy --all-targets --no-deps --profile clippy -- -D warnings'
2026-03-12 23:59:21 +00:00
language: system
types: [rust]
pass_filenames: false
stages: [pre-commit]
- id: rust-test
feat: workflow layer model — NCL-first CI/build/distribution generator Adds a declarative workflow system where .ontology/workflow.ncl declares independent layers (commit-fast, ci-standard, ci-exhaustive), each with a trigger and a set of providers. The generator materialises Woodpecker YAML, justfile recipes, and pre-commit hook stubs from that single declaration. Layers form a set, not a chain — no layer depends on another at the declaration level. Woodpecker steps express fine-grained parallelism internally (lint → test/docs/build). Schema and catalog: - reflection/schemas/workflow.ncl — types, contracts, provider constructors - reflection/defaults/workflow.ncl — standard Rust/Nushell/Nickel catalog (14 validations, 4 builds) Generator (ore workflow generate): - PreCommit: prints hook fragments for manual merge into .pre-commit-config.yaml - Woodpecker: writes per-layer YAML with image selection, tool installs, depends_on chains, and CI-aware command translation (nu --ide-check → find+xargs; markdownlint-cli2 → node:lts image) - Justfile: single justfiles/workflow.just aggregated from all Justfile layers (hoisted out of per-provider loop — was writing N times, now once) Dispatcher: ore workflow validate|list|generate|diff + ore wf v|l|gen|diff Cargo/nextest profiles: - .cargo/config.toml: [profile.ci-test] (debug=0, no-incremental) and [profile.ci] (line-tables-only) — shared by test + docs hooks to reuse .rlib artifacts; CI retains actionable backtraces - .config/nextest.toml: ci-test (fail-fast, no retries) and ci (all failures, one retry) Pre-commit: nextest run with --profile ci-test --cargo-profile ci-test; docs-links hook shares same profile to reuse artifacts Self-application: ontoref declares its own workflow in .ontology/workflow.ncl and the generated .woodpecker/ files are the authoritative CI definition Migration 0014: checks workflow.ncl + both cargo and nextest profiles present Adoption: reflection/templates/ontology/workflow.ncl stub + install_workflow confirm in adopt_ontoref form + step 5 in adoption script template
2026-04-08 14:20:38 +01:00
name: Rust tests (nextest)
entry: bash -c 'cargo nextest run --all-features --workspace --profile ci-test --cargo-profile ci-test'
2026-03-12 23:59:21 +00:00
language: system
types: [rust]
pass_filenames: false
stages: [pre-commit]
2026-03-12 23:59:21 +00:00
- id: cargo-deny
name: Cargo deny (licenses & advisories)
entry: bash -c 'cargo deny check licenses advisories'
language: system
2026-03-13 21:21:06 +00:00
files: Cargo\.(toml|lock)$
2026-03-12 23:59:21 +00:00
pass_filenames: false
stages: [pre-commit]
2026-03-12 23:59:21 +00:00
feat: mode guards, convergence, manifest coverage, doc authoring pattern ## Mode guards and convergence loops (ADR-011) - `Guard` and `Converge` types added to `reflection/schema.ncl` and `reflection/defaults.ncl`. Guards run pre-flight checks (Block/Warn); converge loops iterate until a condition is met (RetryFailed/RetryAll). - `sync-ontology.ncl`: 3 guards + converge (zero-drift condition, max 2 iter). - `coder-workflow.ncl`: guard (coder-dir-exists) + `novelty-check` step. - Rust types in `ontoref-reflection/src/mode.rs`; executor in `executor.rs` evaluates guards before steps and convergence loop after. - `adrs/adr-011-mode-guards-and-convergence.ncl` added. ## Manifest capability completeness - `.ontology/manifest.ncl`: 3 → 19 declared capabilities covering the full action surface (daemon API, modes, Task Composer, QA, bookmarks, etc.). - `sync.nu`: `audit-manifest-coverage` + `sync manifest-check` command. - `validate-project.ncl`: 6th category `manifest-cov`. - Pre-commit hook `manifest-coverage` added. - Migrations `0010-manifest-capability-completeness`, `0011-manifest-coverage-hooks`. ## Rust doc authoring pattern — canonical `///` convention - `#[onto_api]`: `description = "..."` optional when `///` doc comment exists above handler — first line used as fallback. `#[derive(OntologyNode)]` same. - `ontoref-daemon/src/api.rs`: 42 handlers migrated to `///` doc comments; `description = "..."` removed from all `#[onto_api]` blocks. - `sync diff --docs --fail-on-drift`: exits 1 on crate `//!` drift; used by new `docs-drift` pre-commit hook. `docs-links` hook checks rustdoc broken links. - `generator.nu`: mdBook `crates/` chapter — per-crate page from `//!` doc, coverage badge, feature flags, implementing practice nodes. - `.claude/CLAUDE.md`: `### Documentation Authoring (Rust)` section added. - Migration `0012-rust-doc-authoring-pattern`. ## OntologyNode derive fixes - `#[derive(OntologyNode)]`: `name` and `paths` attributes supported; `///` doc fallback for `description`; `artifact_paths` correctly populated. - `Core::from_value` calls `merge_contributors()` behind `#[cfg(feature = "derive")]`. ## Bug fixes - `sync.nu` drift check: exact crate path match (not `str starts-with`); first-path-only rule; split on `. ` not `.` to avoid `.ontology/` truncation. - `find-unclaimed-artifacts`: fixed absolute vs relative path comparison. - Rustdoc broken intra-doc links fixed across all three crates. - `ci-docs` recipe now sets `RUSTDOCFLAGS` and actually fails on errors. mode guards/converge, manifest coverage validation, 19 capabilities (ADR-011) Extend the mode schema with Guard (pre-flight Block/Warn checks) and Converge (RetryFailed/RetryAll post-execution loops) — protocol pushes back on invalid state and iterates until convergence. ADR-011 records the decision to extend modes rather than create a separate action subsystem. Manifest expanded from 3 to 19 capabilities covering the full action surface (compose, plans, backlog graduation, notifications, coder pipeline, forms, templates, drift, quick actions, migrations, config, onboarding). New audit-manifest-coverage validator + pre-commit hook + SessionStart hook ensure agents always see complete project self-description. Bug fix: find-unclaimed-artifacts absolute vs relative path comparison — 19 phantom MISSING items resolved. Health 43% → 100%. Anti-slop: coder novelty-check step (Jaccard overlap against published+QA) inserted between triage and publish in coder-workflow. Justfile restructured into 5 modules (build/test/dev/ci/assets). Migrations 0010-0011 propagate requirements to consumer projects.
2026-03-30 19:08:25 +01:00
- id: docs-links
name: Rustdoc broken intra-doc links
feat: workflow layer model — NCL-first CI/build/distribution generator Adds a declarative workflow system where .ontology/workflow.ncl declares independent layers (commit-fast, ci-standard, ci-exhaustive), each with a trigger and a set of providers. The generator materialises Woodpecker YAML, justfile recipes, and pre-commit hook stubs from that single declaration. Layers form a set, not a chain — no layer depends on another at the declaration level. Woodpecker steps express fine-grained parallelism internally (lint → test/docs/build). Schema and catalog: - reflection/schemas/workflow.ncl — types, contracts, provider constructors - reflection/defaults/workflow.ncl — standard Rust/Nushell/Nickel catalog (14 validations, 4 builds) Generator (ore workflow generate): - PreCommit: prints hook fragments for manual merge into .pre-commit-config.yaml - Woodpecker: writes per-layer YAML with image selection, tool installs, depends_on chains, and CI-aware command translation (nu --ide-check → find+xargs; markdownlint-cli2 → node:lts image) - Justfile: single justfiles/workflow.just aggregated from all Justfile layers (hoisted out of per-provider loop — was writing N times, now once) Dispatcher: ore workflow validate|list|generate|diff + ore wf v|l|gen|diff Cargo/nextest profiles: - .cargo/config.toml: [profile.ci-test] (debug=0, no-incremental) and [profile.ci] (line-tables-only) — shared by test + docs hooks to reuse .rlib artifacts; CI retains actionable backtraces - .config/nextest.toml: ci-test (fail-fast, no retries) and ci (all failures, one retry) Pre-commit: nextest run with --profile ci-test --cargo-profile ci-test; docs-links hook shares same profile to reuse artifacts Self-application: ontoref declares its own workflow in .ontology/workflow.ncl and the generated .woodpecker/ files are the authoritative CI definition Migration 0014: checks workflow.ncl + both cargo and nextest profiles present Adoption: reflection/templates/ontology/workflow.ncl stub + install_workflow confirm in adopt_ontoref form + step 5 in adoption script template
2026-04-08 14:20:38 +01:00
entry: bash -c 'RUSTDOCFLAGS="-D rustdoc::broken-intra-doc-links -D rustdoc::private-intra-doc-links" cargo doc --no-deps --workspace --profile ci-test -q'
feat: mode guards, convergence, manifest coverage, doc authoring pattern ## Mode guards and convergence loops (ADR-011) - `Guard` and `Converge` types added to `reflection/schema.ncl` and `reflection/defaults.ncl`. Guards run pre-flight checks (Block/Warn); converge loops iterate until a condition is met (RetryFailed/RetryAll). - `sync-ontology.ncl`: 3 guards + converge (zero-drift condition, max 2 iter). - `coder-workflow.ncl`: guard (coder-dir-exists) + `novelty-check` step. - Rust types in `ontoref-reflection/src/mode.rs`; executor in `executor.rs` evaluates guards before steps and convergence loop after. - `adrs/adr-011-mode-guards-and-convergence.ncl` added. ## Manifest capability completeness - `.ontology/manifest.ncl`: 3 → 19 declared capabilities covering the full action surface (daemon API, modes, Task Composer, QA, bookmarks, etc.). - `sync.nu`: `audit-manifest-coverage` + `sync manifest-check` command. - `validate-project.ncl`: 6th category `manifest-cov`. - Pre-commit hook `manifest-coverage` added. - Migrations `0010-manifest-capability-completeness`, `0011-manifest-coverage-hooks`. ## Rust doc authoring pattern — canonical `///` convention - `#[onto_api]`: `description = "..."` optional when `///` doc comment exists above handler — first line used as fallback. `#[derive(OntologyNode)]` same. - `ontoref-daemon/src/api.rs`: 42 handlers migrated to `///` doc comments; `description = "..."` removed from all `#[onto_api]` blocks. - `sync diff --docs --fail-on-drift`: exits 1 on crate `//!` drift; used by new `docs-drift` pre-commit hook. `docs-links` hook checks rustdoc broken links. - `generator.nu`: mdBook `crates/` chapter — per-crate page from `//!` doc, coverage badge, feature flags, implementing practice nodes. - `.claude/CLAUDE.md`: `### Documentation Authoring (Rust)` section added. - Migration `0012-rust-doc-authoring-pattern`. ## OntologyNode derive fixes - `#[derive(OntologyNode)]`: `name` and `paths` attributes supported; `///` doc fallback for `description`; `artifact_paths` correctly populated. - `Core::from_value` calls `merge_contributors()` behind `#[cfg(feature = "derive")]`. ## Bug fixes - `sync.nu` drift check: exact crate path match (not `str starts-with`); first-path-only rule; split on `. ` not `.` to avoid `.ontology/` truncation. - `find-unclaimed-artifacts`: fixed absolute vs relative path comparison. - Rustdoc broken intra-doc links fixed across all three crates. - `ci-docs` recipe now sets `RUSTDOCFLAGS` and actually fails on errors. mode guards/converge, manifest coverage validation, 19 capabilities (ADR-011) Extend the mode schema with Guard (pre-flight Block/Warn checks) and Converge (RetryFailed/RetryAll post-execution loops) — protocol pushes back on invalid state and iterates until convergence. ADR-011 records the decision to extend modes rather than create a separate action subsystem. Manifest expanded from 3 to 19 capabilities covering the full action surface (compose, plans, backlog graduation, notifications, coder pipeline, forms, templates, drift, quick actions, migrations, config, onboarding). New audit-manifest-coverage validator + pre-commit hook + SessionStart hook ensure agents always see complete project self-description. Bug fix: find-unclaimed-artifacts absolute vs relative path comparison — 19 phantom MISSING items resolved. Health 43% → 100%. Anti-slop: coder novelty-check step (Jaccard overlap against published+QA) inserted between triage and publish in coder-workflow. Justfile restructured into 5 modules (build/test/dev/ci/assets). Migrations 0010-0011 propagate requirements to consumer projects.
2026-03-30 19:08:25 +01:00
language: system
types: [rust]
pass_filenames: false
stages: [pre-commit]
- id: docs-drift
name: Crate //! doc drift check
entry: bash -c 'nu -c "use ./reflection/modules/sync.nu; sync diff --docs --fail-on-drift"'
language: system
types: [rust]
pass_filenames: false
stages: [pre-commit]
- id: manifest-coverage
name: Manifest capability completeness
entry: bash -c 'ONTOREF_ROOT="$(pwd)" ONTOREF_PROJECT_ROOT="$(pwd)" nu --no-config-file -c "use ./reflection/modules/sync.nu *; sync manifest-check"'
language: system
files: (\.ontology/|reflection/modes/|reflection/forms/).*\.ncl$
pass_filenames: false
stages: [pre-commit]
2026-03-12 23:59:21 +00:00
# ============================================================================
# Nushell Hooks (optional - enable if using Nushell)
# ============================================================================
# - repo: local
# hooks:
# - id: nushell-check
# name: Nushell validation (nu --ide-check)
# entry: >-
# bash -c 'for f in $(git diff --cached --name-only --diff-filter=ACM | grep "\.nu$"); do
# echo "Checking: $f"; nu --ide-check 100 "$f" || exit 1; done'
# language: system
# types: [file]
# files: \.nu$
# pass_filenames: false
# stages: [pre-commit]
# ============================================================================
# Nickel Hooks (optional - enable if using Nickel)
# ============================================================================
# - repo: local
# hooks:
# - id: nickel-typecheck
# name: Nickel type checking
# entry: >-
# bash -c 'export NICKEL_IMPORT_PATH="../:."; for f in $(git diff --cached --name-only --diff-filter=ACM | grep "\.ncl$"); do
# echo "Checking: $f"; nickel typecheck "$f" || exit 1; done'
# language: system
# types: [file]
# files: \.ncl$
# pass_filenames: false
# stages: [pre-commit]
# ============================================================================
# Bash Hooks (optional - enable if using Bash)
# ============================================================================
# - repo: local
# hooks:
# - id: shellcheck
# name: Shellcheck (bash linting)
# entry: shellcheck
# language: system
# types: [shell]
# stages: [pre-commit]
#
# - id: shfmt
# name: Shell script formatting
# entry: bash -c 'shfmt -i 2 -d'
# language: system
# types: [shell]
# stages: [pre-commit]
# ============================================================================
# Markdown Hooks (RECOMMENDED - enable for documentation quality)
# ============================================================================
- repo: local
hooks:
- id: markdownlint
name: Markdown linting (markdownlint-cli2)
entry: markdownlint-cli2
language: system
pass_filenames: false
stages: [pre-commit]
# ============================================================================
# General Pre-commit Hooks
# ============================================================================
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.5.0
hooks:
- id: check-added-large-files
args: ['--maxkb=1000']
2026-03-29 00:19:56 +00:00
exclude: (^assets/presentation/|node_modules/)
2026-03-12 23:59:21 +00:00
- id: check-case-conflict
2026-03-29 00:19:56 +00:00
exclude: node_modules/
2026-03-12 23:59:21 +00:00
- id: check-merge-conflict
2026-03-29 00:19:56 +00:00
exclude: node_modules/
2026-03-12 23:59:21 +00:00
- id: check-toml
2026-03-29 00:19:56 +00:00
exclude: (^assets/presentation/|node_modules/)
2026-03-12 23:59:21 +00:00
- id: check-yaml
2026-03-29 00:19:56 +00:00
exclude: (^\.woodpecker/|^assets/presentation/|node_modules/)
2026-03-12 23:59:21 +00:00
- id: end-of-file-fixer
2026-03-29 00:19:56 +00:00
exclude: (^assets/presentation/|node_modules/)
2026-03-12 23:59:21 +00:00
- id: trailing-whitespace
2026-03-29 00:19:56 +00:00
exclude: (\.md$|^assets/presentation/|node_modules/)
2026-03-12 23:59:21 +00:00
- id: mixed-line-ending
2026-03-29 00:19:56 +00:00
exclude: (^assets/presentation/|node_modules/)