13b03d6edf
## Mode guards and convergence loops (ADR-011)
- `Guard` and `Converge` types added to `reflection/schema.ncl` and
`reflection/defaults.ncl`. Guards run pre-flight checks (Block/Warn);
converge loops iterate until a condition is met (RetryFailed/RetryAll).
- `sync-ontology.ncl`: 3 guards + converge (zero-drift condition, max 2 iter).
- `coder-workflow.ncl`: guard (coder-dir-exists) + `novelty-check` step.
- Rust types in `ontoref-reflection/src/mode.rs`; executor in `executor.rs`
evaluates guards before steps and convergence loop after.
- `adrs/adr-011-mode-guards-and-convergence.ncl` added.
## Manifest capability completeness
- `.ontology/manifest.ncl`: 3 → 19 declared capabilities covering the full
action surface (daemon API, modes, Task Composer, QA, bookmarks, etc.).
- `sync.nu`: `audit-manifest-coverage` + `sync manifest-check` command.
- `validate-project.ncl`: 6th category `manifest-cov`.
- Pre-commit hook `manifest-coverage` added.
- Migrations `0010-manifest-capability-completeness`,
`0011-manifest-coverage-hooks`.
## Rust doc authoring pattern — canonical `///` convention
- `#[onto_api]`: `description = "..."` optional when `///` doc comment exists
above handler — first line used as fallback. `#[derive(OntologyNode)]` same.
- `ontoref-daemon/src/api.rs`: 42 handlers migrated to `///` doc comments;
`description = "..."` removed from all `#[onto_api]` blocks.
- `sync diff --docs --fail-on-drift`: exits 1 on crate `//!` drift; used by
new `docs-drift` pre-commit hook. `docs-links` hook checks rustdoc broken links.
- `generator.nu`: mdBook `crates/` chapter — per-crate page from `//!` doc,
coverage badge, feature flags, implementing practice nodes.
- `.claude/CLAUDE.md`: `### Documentation Authoring (Rust)` section added.
- Migration `0012-rust-doc-authoring-pattern`.
## OntologyNode derive fixes
- `#[derive(OntologyNode)]`: `name` and `paths` attributes supported; `///`
doc fallback for `description`; `artifact_paths` correctly populated.
- `Core::from_value` calls `merge_contributors()` behind `#[cfg(feature = "derive")]`.
## Bug fixes
- `sync.nu` drift check: exact crate path match (not `str starts-with`);
first-path-only rule; split on `. ` not `.` to avoid `.ontology/` truncation.
- `find-unclaimed-artifacts`: fixed absolute vs relative path comparison.
- Rustdoc broken intra-doc links fixed across all three crates.
- `ci-docs` recipe now sets `RUSTDOCFLAGS` and actually fails on errors.
mode guards/converge, manifest coverage validation, 19 capabilities (ADR-011)
Extend the mode schema with Guard (pre-flight Block/Warn checks) and Converge
(RetryFailed/RetryAll post-execution loops) — protocol pushes back on invalid
state and iterates until convergence. ADR-011 records the decision to extend
modes rather than create a separate action subsystem.
Manifest expanded from 3 to 19 capabilities covering the full action surface
(compose, plans, backlog graduation, notifications, coder pipeline, forms,
templates, drift, quick actions, migrations, config, onboarding). New
audit-manifest-coverage validator + pre-commit hook + SessionStart hook
ensure agents always see complete project self-description.
Bug fix: find-unclaimed-artifacts absolute vs relative path comparison —
19 phantom MISSING items resolved. Health 43% → 100%.
Anti-slop: coder novelty-check step (Jaccard overlap against published+QA)
inserted between triage and publish in coder-workflow.
Justfile restructured into 5 modules (build/test/dev/ci/assets).
Migrations 0010-0011 propagate requirements to consumer projects.
160 lines
5.5 KiB
YAML
160 lines
5.5 KiB
YAML
# Pre-commit Framework Configuration
|
|
# Generated by dev-system/ci
|
|
# Configures git pre-commit hooks for Rust projects
|
|
|
|
repos:
|
|
# ============================================================================
|
|
# Rust Hooks
|
|
# ============================================================================
|
|
- repo: local
|
|
hooks:
|
|
- id: rust-fmt
|
|
name: Rust formatting (cargo +nightly fmt)
|
|
entry: bash -c 'cargo +nightly fmt --all -- --check'
|
|
language: system
|
|
types: [rust]
|
|
pass_filenames: false
|
|
stages: [pre-commit]
|
|
|
|
- id: rust-clippy
|
|
name: Rust linting (cargo clippy)
|
|
entry: bash -c 'CARGO_TARGET_DIR=target cargo clippy --all-targets --no-deps --profile clippy -- -D warnings'
|
|
language: system
|
|
types: [rust]
|
|
pass_filenames: false
|
|
stages: [pre-commit]
|
|
|
|
- id: rust-test
|
|
name: Rust tests
|
|
entry: bash -c 'cargo test --all-features --workspace'
|
|
language: system
|
|
types: [rust]
|
|
pass_filenames: false
|
|
stages: [pre-commit]
|
|
|
|
- id: cargo-deny
|
|
name: Cargo deny (licenses & advisories)
|
|
entry: bash -c 'cargo deny check licenses advisories'
|
|
language: system
|
|
files: Cargo\.(toml|lock)$
|
|
pass_filenames: false
|
|
stages: [pre-commit]
|
|
|
|
- id: docs-links
|
|
name: Rustdoc broken intra-doc links
|
|
entry: bash -c 'RUSTDOCFLAGS="-D rustdoc::broken-intra-doc-links -D rustdoc::private-intra-doc-links" cargo doc --no-deps --workspace -q'
|
|
language: system
|
|
types: [rust]
|
|
pass_filenames: false
|
|
stages: [pre-commit]
|
|
|
|
- id: docs-drift
|
|
name: Crate //! doc drift check
|
|
entry: bash -c 'nu -c "use ./reflection/modules/sync.nu; sync diff --docs --fail-on-drift"'
|
|
language: system
|
|
types: [rust]
|
|
pass_filenames: false
|
|
stages: [pre-commit]
|
|
|
|
- id: manifest-coverage
|
|
name: Manifest capability completeness
|
|
entry: bash -c 'ONTOREF_ROOT="$(pwd)" ONTOREF_PROJECT_ROOT="$(pwd)" nu --no-config-file -c "use ./reflection/modules/sync.nu *; sync manifest-check"'
|
|
language: system
|
|
files: (\.ontology/|reflection/modes/|reflection/forms/).*\.ncl$
|
|
pass_filenames: false
|
|
stages: [pre-commit]
|
|
|
|
# ============================================================================
|
|
# Nushell Hooks (optional - enable if using Nushell)
|
|
# ============================================================================
|
|
# - repo: local
|
|
# hooks:
|
|
# - id: nushell-check
|
|
# name: Nushell validation (nu --ide-check)
|
|
# entry: >-
|
|
# bash -c 'for f in $(git diff --cached --name-only --diff-filter=ACM | grep "\.nu$"); do
|
|
# echo "Checking: $f"; nu --ide-check 100 "$f" || exit 1; done'
|
|
# language: system
|
|
# types: [file]
|
|
# files: \.nu$
|
|
# pass_filenames: false
|
|
# stages: [pre-commit]
|
|
|
|
# ============================================================================
|
|
# Nickel Hooks (optional - enable if using Nickel)
|
|
# ============================================================================
|
|
# - repo: local
|
|
# hooks:
|
|
# - id: nickel-typecheck
|
|
# name: Nickel type checking
|
|
# entry: >-
|
|
# bash -c 'export NICKEL_IMPORT_PATH="../:."; for f in $(git diff --cached --name-only --diff-filter=ACM | grep "\.ncl$"); do
|
|
# echo "Checking: $f"; nickel typecheck "$f" || exit 1; done'
|
|
# language: system
|
|
# types: [file]
|
|
# files: \.ncl$
|
|
# pass_filenames: false
|
|
# stages: [pre-commit]
|
|
|
|
# ============================================================================
|
|
# Bash Hooks (optional - enable if using Bash)
|
|
# ============================================================================
|
|
# - repo: local
|
|
# hooks:
|
|
# - id: shellcheck
|
|
# name: Shellcheck (bash linting)
|
|
# entry: shellcheck
|
|
# language: system
|
|
# types: [shell]
|
|
# stages: [pre-commit]
|
|
#
|
|
# - id: shfmt
|
|
# name: Shell script formatting
|
|
# entry: bash -c 'shfmt -i 2 -d'
|
|
# language: system
|
|
# types: [shell]
|
|
# stages: [pre-commit]
|
|
|
|
# ============================================================================
|
|
# Markdown Hooks (RECOMMENDED - enable for documentation quality)
|
|
# ============================================================================
|
|
- repo: local
|
|
hooks:
|
|
- id: markdownlint
|
|
name: Markdown linting (markdownlint-cli2)
|
|
entry: markdownlint-cli2
|
|
language: system
|
|
pass_filenames: false
|
|
stages: [pre-commit]
|
|
|
|
# ============================================================================
|
|
# General Pre-commit Hooks
|
|
# ============================================================================
|
|
- repo: https://github.com/pre-commit/pre-commit-hooks
|
|
rev: v4.5.0
|
|
hooks:
|
|
- id: check-added-large-files
|
|
args: ['--maxkb=1000']
|
|
exclude: (^assets/presentation/|node_modules/)
|
|
|
|
- id: check-case-conflict
|
|
exclude: node_modules/
|
|
|
|
- id: check-merge-conflict
|
|
exclude: node_modules/
|
|
|
|
- id: check-toml
|
|
exclude: (^assets/presentation/|node_modules/)
|
|
|
|
- id: check-yaml
|
|
exclude: (^\.woodpecker/|^assets/presentation/|node_modules/)
|
|
|
|
- id: end-of-file-fixer
|
|
exclude: (^assets/presentation/|node_modules/)
|
|
|
|
- id: trailing-whitespace
|
|
exclude: (\.md$|^assets/presentation/|node_modules/)
|
|
|
|
- id: mixed-line-ending
|
|
exclude: (^assets/presentation/|node_modules/)
|