From 3e747e1317dce20a79f5e48c003201d913127fae Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jesu=CC=81s=20Pe=CC=81rez?= <jpl@jesusperez.com>
Date: Fri, 17 Apr 2026 09:16:21 +0100
Subject: [PATCH] refactor(6 production files): plugins_defs + setup + platform
 + oci + auth_core (ADR-025 L2)

Six production 2-star files -> selective.

plugins_defs.nu:
  utils/nickel_processor.nu [ncl-eval] (kept, already selective)
  utils/ + config/accessor   DROPPED (both dead)

setup/provctl_integration.nu:
  setup/mod.nu   [8 symbols]
  setup/detection DROPPED (dead)

setup/provider.nu:
  setup/mod.nu     [9 symbols]
  setup/validation DROPPED (dead)

platform/autostart.nu:
  platform/target.nu [get-deployment-service-config get-enabled-services]
  platform/health.nu [check-service-health]

plugins/auth_core.nu:
  config/accessor/core.nu [config-get]
  commands/traits.nu      [get-command-metadata]

oci/client.nu:
  utils/logging.nu [log-debug log-error log-info]
  config/accessor  DROPPED (dead)

Validation: all 6 nu --ide-check 50 -> 0 errors.

Refs: ADR-025
---
 nulib/lib_provisioning/oci/client.nu                | 5 +++--
 nulib/lib_provisioning/platform/autostart.nu        | 5 +++--
 nulib/lib_provisioning/plugins/auth_core.nu         | 5 +++--
 nulib/lib_provisioning/plugins_defs.nu              | 6 +++---
 nulib/lib_provisioning/setup/provctl_integration.nu | 8 ++++++--
 nulib/lib_provisioning/setup/provider.nu            | 9 +++++++--
 6 files changed, 25 insertions(+), 13 deletions(-)

diff --git a/nulib/lib_provisioning/oci/client.nu b/nulib/lib_provisioning/oci/client.nu
index bc52a42..d7d10e4 100644
--- a/nulib/lib_provisioning/oci/client.nu
+++ b/nulib/lib_provisioning/oci/client.nu
@@ -1,8 +1,9 @@
 # OCI Registry Client
 # Handles OCI artifact operations (pull, push, list, search)
 
-use ../config/accessor.nu *
-use ../utils/logging.nu *
+# Selective imports (ADR-025 Phase 3 Layer 2).
+# config/accessor star-import was dead — dropped.
+use lib_provisioning/utils/logging.nu [log-debug log-error log-info]
 
 # OCI client configuration
 export def get-oci-config [] {
diff --git a/nulib/lib_provisioning/platform/autostart.nu b/nulib/lib_provisioning/platform/autostart.nu
index 06ccd7c..560430f 100644
--- a/nulib/lib_provisioning/platform/autostart.nu
+++ b/nulib/lib_provisioning/platform/autostart.nu
@@ -1,7 +1,8 @@
 # Platform Service Auto-Start
 
-use target.nu *
-use health.nu *
+# Selective imports (ADR-025 Phase 3 Layer 2).
+use lib_provisioning/platform/target.nu [get-deployment-service-config get-enabled-services]
+use lib_provisioning/platform/health.nu [check-service-health]
 
 # Get binary name from service name
 def get-binary-name [service: string] {
diff --git a/nulib/lib_provisioning/plugins/auth_core.nu b/nulib/lib_provisioning/plugins/auth_core.nu
index ffdb36a..8768b05 100644
--- a/nulib/lib_provisioning/plugins/auth_core.nu
+++ b/nulib/lib_provisioning/plugins/auth_core.nu
@@ -9,8 +9,9 @@
 # Authentication Plugin Wrapper with HTTP Fallback
 # Provides graceful degradation to HTTP API when nu_plugin_auth is unavailable
 
-use ../config/accessor.nu *
-use ../commands/traits.nu *
+# Selective imports (ADR-025 Phase 3 Layer 2).
+use lib_provisioning/config/accessor/core.nu [config-get]
+use lib_provisioning/commands/traits.nu [get-command-metadata]
 
 # Check if auth plugin is available (registered with Nushell)
 def is-plugin-available [] {
diff --git a/nulib/lib_provisioning/plugins_defs.nu b/nulib/lib_provisioning/plugins_defs.nu
index 6d10301..248751d 100644
--- a/nulib/lib_provisioning/plugins_defs.nu
+++ b/nulib/lib_provisioning/plugins_defs.nu
@@ -1,6 +1,6 @@
-use utils *
-use config/accessor.nu *
-use ./utils/nickel_processor.nu [ncl-eval]
+# Selective imports (ADR-025 Phase 3 Layer 2).
+# Both utils/ and config/accessor star-imports were dead — dropped.
+use lib_provisioning/utils/nickel_processor.nu [ncl-eval]
 
 export def clip_copy [
   msg: string
diff --git a/nulib/lib_provisioning/setup/provctl_integration.nu b/nulib/lib_provisioning/setup/provctl_integration.nu
index 035971b..4bdb398 100644
--- a/nulib/lib_provisioning/setup/provctl_integration.nu
+++ b/nulib/lib_provisioning/setup/provctl_integration.nu
@@ -3,8 +3,12 @@
 # Graceful fallback when provctl is not installed
 # Follows Nushell guidelines: explicit types, single purpose, no try-catch
 
-use ./mod.nu *
-use ./detection.nu *
+# Selective imports (ADR-025 Phase 3 Layer 2).
+# setup/detection star-import was dead — dropped.
+use lib_provisioning/setup/mod.nu [
+    get-timestamp-iso8601 load-config-toml print-setup-error print-setup-header
+    print-setup-info print-setup-success print-setup-warning save-config-toml
+]
 
 # ============================================================================
 # PROVCTL DETECTION
diff --git a/nulib/lib_provisioning/setup/provider.nu b/nulib/lib_provisioning/setup/provider.nu
index 6616e5d..62f1550 100644
--- a/nulib/lib_provisioning/setup/provider.nu
+++ b/nulib/lib_provisioning/setup/provider.nu
@@ -2,8 +2,13 @@
 # Manages infrastructure provider setup and configuration (UpCloud, AWS, Hetzner)
 # Follows Nushell guidelines: explicit types, single purpose, no try-catch
 
-use ./mod.nu *
-use ./validation.nu *
+# Selective imports (ADR-025 Phase 3 Layer 2).
+# setup/validation star-import was dead — dropped.
+use lib_provisioning/setup/mod.nu [
+    get-config-base-path get-timestamp-iso8601 load-config-toml
+    print-setup-error print-setup-header print-setup-info print-setup-success
+    print-setup-warning save-config-toml
+]
 
 # ============================================================================
 # PROVIDER VALIDATION