From b5515545197c514d595ff7ef3b1225c0aab8c65a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jesu=CC=81s=20Pe=CC=81rez?= Date: Fri, 17 Apr 2026 08:29:31 +0100 Subject: [PATCH] refactor(setup/mod): selective imports + drop dead logging import (ADR-025 L3) setup/mod.nu had 4 star-imports. Resolution per target: Converted to selective: config/accessor.nu -> [config-get] 1 symbol utils.nu (re-export) -> [create_versions_file ...] 4 symbols config.nu (re-export) -> [env_file_providers ...] 2 symbols Dropped: utils/logging.nu -> 0 used symbols in this file DEAD Also promoted the accessor import to absolute path (lib_provisioning/config/accessor/core.nu) per ADR-025 rule. Validation: nu --ide-check 50 setup/mod.nu -> 0 errors Refs: ADR-025, .coder/benchmarks/phase2-transitivity.md Layer 3 --- nulib/lib_provisioning/setup/mod.nu | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/nulib/lib_provisioning/setup/mod.nu b/nulib/lib_provisioning/setup/mod.nu index 524f12e..360fa9c 100644 --- a/nulib/lib_provisioning/setup/mod.nu +++ b/nulib/lib_provisioning/setup/mod.nu @@ -2,12 +2,13 @@ # Orchestrates all setup subcommands with helper functions for configuration management # Follows Nushell guidelines: explicit types, single purpose, no try-catch -use ../config/accessor.nu * -use ../utils/logging.nu * +# Selective imports (ADR-025 Phase 3 Layer 3). +# utils/logging.nu star-import was dead (no symbols used in this file) — removed. +use lib_provisioning/config/accessor/core.nu [config-get] -# Re-export existing utilities and config helpers -export use utils.nu * -export use config.nu * +# Re-export existing utilities and config helpers (selective) +export use utils.nu [create_versions_file providers_install setup_config_path tools_install] +export use config.nu [env_file_providers install_config] # Note: wizard.nu is imported by callers directly - avoid circular import with mod.nu # ============================================================================