From ded87bfd652eebb38ff17c1466a65da7d2cd6850 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jesu=CC=81s=20Pe=CC=81rez?= <jpl@jesusperez.com>
Date: Fri, 17 Apr 2026 08:50:07 +0100
Subject: [PATCH] refactor(utils/version + service-check): selective imports
 (ADR-025 L2)

Three utils/ files, 3 star-imports each -> selective.

utils/version/taskserv.nu:
  utils/interface.nu [_print]
  version/core.nu    DROPPED (dead)
  version/loader.nu  DROPPED (dead)

utils/version/registry.nu:
  version/core.nu     [fetch-versions]
  version/taskserv.nu [discover-taskserv-configurations]
  utils/interface.nu  [_print]

utils/service-check.nu:
  platform/target.nu          [get-deployment-service-config get-enabled-services]
  platform/health.nu          [check-service-health]
  platform/service-manager.nu [get-external-services]

Validation: all 3 nu --ide-check 50 -> 0 errors.

Refs: ADR-025
---
 nulib/lib_provisioning/utils/service-check.nu    | 9 ++++++---
 nulib/lib_provisioning/utils/version/registry.nu | 7 ++++---
 nulib/lib_provisioning/utils/version/taskserv.nu | 6 +++---
 3 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/nulib/lib_provisioning/utils/service-check.nu b/nulib/lib_provisioning/utils/service-check.nu
index b8f0384..e786c0f 100644
--- a/nulib/lib_provisioning/utils/service-check.nu
+++ b/nulib/lib_provisioning/utils/service-check.nu
@@ -9,9 +9,12 @@
 # - Clean error messages with short aliases
 # - No stack traces (uses print + return, not error make)
 
-use ../platform/target.nu *
-use ../platform/health.nu *
-use ../platform/service-manager.nu *
+# Selective imports (ADR-025 Phase 3 Layer 2).
+use lib_provisioning/platform/target.nu [
+    get-deployment-service-config get-enabled-services
+]
+use lib_provisioning/platform/health.nu [check-service-health]
+use lib_provisioning/platform/service-manager.nu [get-external-services]
 
 # Check external services locally (avoiding startup.nu import due to syntax errors in that file)
 def check-external-services-internal [external_config: record]: nothing -> list {
diff --git a/nulib/lib_provisioning/utils/version/registry.nu b/nulib/lib_provisioning/utils/version/registry.nu
index 3bb66c4..8b26351 100644
--- a/nulib/lib_provisioning/utils/version/registry.nu
+++ b/nulib/lib_provisioning/utils/version/registry.nu
@@ -2,9 +2,10 @@
 # Version registry management for taskservs
 # Handles the central version registry and integrates with taskserv configurations
 
-use ./core.nu *
-use ./taskserv.nu *
-use ../interface.nu *
+# Selective imports (ADR-025 Phase 3 Layer 2).
+use lib_provisioning/utils/version/core.nu [fetch-versions]
+use lib_provisioning/utils/version/taskserv.nu [discover-taskserv-configurations]
+use lib_provisioning/utils/interface.nu [_print]
 
 # Load the version registry
 export def load-version-registry [
diff --git a/nulib/lib_provisioning/utils/version/taskserv.nu b/nulib/lib_provisioning/utils/version/taskserv.nu
index 5255c69..62b2fc4 100644
--- a/nulib/lib_provisioning/utils/version/taskserv.nu
+++ b/nulib/lib_provisioning/utils/version/taskserv.nu
@@ -2,9 +2,9 @@
 # Taskserv version extraction and management utilities
 # Handles Nickel taskserv files and version configuration
 
-use ./core.nu *
-use ./loader.nu *
-use ../interface.nu *
+# Selective imports (ADR-025 Phase 3 Layer 2).
+# version/core.nu and version/loader.nu star-imports were dead — dropped.
+use lib_provisioning/utils/interface.nu [_print]
 
 # Extract version field from Nickel taskserv files
 export def extract-nickel-version [