From ee68806cb10ca673bff694017545e1dff974f8a0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jesu=CC=81s=20Pe=CC=81rez?= Date: Fri, 17 Apr 2026 08:58:20 +0100 Subject: [PATCH] refactor(cmd/lib + config/loader/core + config/encryption): selective (ADR-025 L2) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Three files with 3 stars each -> selective. cmd/lib.nu: utils/init.nu [get-workspace-path get-provisioning-infra-path] (kept) sops/lib.nu [find-sops-key on_sops] config/accessor DROPPED (dead) utils/ui.nu DROPPED (dead) config/loader/core.nu: All 3 star-imports (interpolators, context_manager, sops_handler) were dead — NONE of their exports are used in the file body. All dropped. config/encryption.nu: sops/lib.nu [3 symbols — get-sops-age-key-file is_sops_file on_sops] kms/lib.nu [on_kms] plugins/kms.nu [3 symbols] (already selective; kept) config/accessor DROPPED (dead) Deferred from this batch: cmd/environment.nu. It calls 7+ functions that are not defined anywhere in the codebase (list-available-environments, get-current-environment, switch-environment, init-environment-config, show-config, compare-environments, etc.). Converting its star-imports to selective would surface those as undefined symbol errors. Needs the Blocker-1 style treatment (stubs or elimination) in a dedicated commit. Tracked as follow-up. Validation: all 3 nu --ide-check 50 -> 0 errors. Refs: ADR-025 --- nulib/lib_provisioning/cmd/lib.nu | 8 ++++---- nulib/lib_provisioning/config/encryption.nu | 9 +++++---- nulib/lib_provisioning/config/loader/core.nu | 6 +++--- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/nulib/lib_provisioning/cmd/lib.nu b/nulib/lib_provisioning/cmd/lib.nu index 6f43151..e85ac2c 100644 --- a/nulib/lib_provisioning/cmd/lib.nu +++ b/nulib/lib_provisioning/cmd/lib.nu @@ -1,9 +1,9 @@ # Made for prepare and postrun -use ../config/accessor.nu * -use ../utils/ui.nu * -use ../utils/init.nu [get-workspace-path get-provisioning-infra-path] -use ../sops * +# Selective imports (ADR-025 Phase 3 Layer 2). +# config/accessor and utils/ui star-imports were dead — dropped. +use lib_provisioning/utils/init.nu [get-workspace-path get-provisioning-infra-path] +use lib_provisioning/sops/lib.nu [find-sops-key on_sops] export def log_debug [ msg: string diff --git a/nulib/lib_provisioning/config/encryption.nu b/nulib/lib_provisioning/config/encryption.nu index 6f37acc..5b78a0c 100644 --- a/nulib/lib_provisioning/config/encryption.nu +++ b/nulib/lib_provisioning/config/encryption.nu @@ -3,10 +3,11 @@ # Optimized with nu_plugin_kms for 10x performance improvement use std log -use ../sops/lib.nu * -use ../kms/lib.nu * -use ../plugins/kms.nu [plugin-kms-decrypt plugin-kms-encrypt plugin-kms-info] -use accessor.nu * +# Selective imports (ADR-025 Phase 3 Layer 2). +# config/accessor star-import was dead — dropped. +use lib_provisioning/sops/lib.nu [get-sops-age-key-file is_sops_file on_sops] +use lib_provisioning/kms/lib.nu [on_kms] +use lib_provisioning/plugins/kms.nu [plugin-kms-decrypt plugin-kms-encrypt plugin-kms-info] # Detect if a config file is encrypted export def is-encrypted-config [ diff --git a/nulib/lib_provisioning/config/loader/core.nu b/nulib/lib_provisioning/config/loader/core.nu index e805419..16906cb 100644 --- a/nulib/lib_provisioning/config/loader/core.nu +++ b/nulib/lib_provisioning/config/loader/core.nu @@ -3,9 +3,9 @@ # Dependencies: interpolators, validators, context_manager, sops_handler, cache modules use std log -use ../interpolators.nu * -use ../context_manager.nu * -use ../sops_handler.nu * +# Selective imports (ADR-025 Phase 3 Layer 2). +# All 3 star-imports (interpolators, context_manager, sops_handler) were dead +# in this file (no exported symbols used). Dropped. # Cache integration - temporarily disabled due to Nushell parser issues # use ../cache/core.nu *