Commit graph

6 commits

Author SHA1 Message Date
Jesús Pérez
ee68806cb1
refactor(cmd/lib + config/loader/core + config/encryption): selective (ADR-025 L2)
Three files with 3 stars each -> selective.

cmd/lib.nu:
  utils/init.nu     [get-workspace-path get-provisioning-infra-path] (kept)
  sops/lib.nu       [find-sops-key on_sops]
  config/accessor   DROPPED (dead)
  utils/ui.nu       DROPPED (dead)

config/loader/core.nu:
  All 3 star-imports (interpolators, context_manager, sops_handler) were
  dead — NONE of their exports are used in the file body. All dropped.

config/encryption.nu:
  sops/lib.nu          [3 symbols — get-sops-age-key-file is_sops_file on_sops]
  kms/lib.nu           [on_kms]
  plugins/kms.nu       [3 symbols] (already selective; kept)
  config/accessor      DROPPED (dead)

Deferred from this batch: cmd/environment.nu.
It calls 7+ functions that are not defined anywhere in the codebase
(list-available-environments, get-current-environment, switch-environment,
init-environment-config, show-config, compare-environments, etc.).
Converting its star-imports to selective would surface those as undefined
symbol errors. Needs the Blocker-1 style treatment (stubs or elimination)
in a dedicated commit. Tracked as follow-up.

Validation: all 3 nu --ide-check 50 -> 0 errors.

Refs: ADR-025
2026-04-17 08:58:20 +01:00
Jesús Pérez
037acd52eb
refactor(lib): remove dead export-env blocks (ADR-025 blocker 4)
Two export-env blocks in lib_provisioning/ ran at module load time as side
effects of the lib_provisioning/mod.nu star-import chain. ADR-025 empties
that chain; the side effects were never going to fire again and neither has
a remaining reader that depends on them.

1. lib_provisioning/cmd/env.nu
   Former block: called check_env (a pre-flight gate for PROVISIONING_VARS /
   PROVISIONING_WORKSPACE_PATH / PROVISIONING_WK_ENV_PATH existence) and set
   $env.PROVISIONING_DEBUG = false. Nobody imports cmd/env.nu directly; every
   downstream reader of PROVISIONING_DEBUG either sets it explicitly via a
   --debug flag branch or reads it with `?` + default fallback.

2. lib_provisioning/providers/registry.nu
   Former block: $env.PROVIDER_REGISTRY_INITIALIZED = false. The four read
   sites in registry.nu already use `$env.PROVIDER_REGISTRY_INITIALIZED? |
   default false`; the unset state is equivalent to false. Zero behaviour
   change.

Both files now carry a comment explaining the removal so future contributors
understand the history without reading ADR-025.

Refs: ADR-025, .coder/benchmarks/phase2-findings.md export-env decisions
2026-04-17 07:47:19 +01:00
Jesús Pérez
894046ef5a
feat(core): three-layer DAG, unified component arch, commands-registry cache, Nushell 0.112.2 migration
- DAG architecture: `dag show/validate/export` (nulib/main_provisioning/dag.nu),
    config loader (lib_provisioning/config/loader/dag.nu), taskserv dag-executor.
    Backed by schemas/lib/dag/*.ncl; orchestrator emits NATS events via
    WorkspaceComposition::into_workflow. See ADR-020, ADR-021.
  - Unified Component Architecture: components/mod.nu, main_provisioning/
    {components,workflow,extensions,ontoref-queries}.nu. Full workflow engine with
    topological sort and NATS subject emission. Blocks A-H complete (libre-daoshi).
  - Commands-registry: nulib/commands-registry.ncl (Nickel source, 314 lines) +
    JSON cache at ~/.cache/provisioning/commands-registry.json rebuilt on source
    change. cli/provisioning fast-path alias expansion avoids cold Nu startup.
    ADDING_COMMANDS.md documents new-command workflow.
  - Platform service manager: service-manager.nu (+573), startup.nu (+611),
    service-check.nu (+255); autostart/bootstrap/health/target refactored.
  - Nushell 0.112.2 migration: removed all try/catch and bash redirections;
    external commands prefixed with ^; type signatures enforced. Driven by
    scripts/refactor-try-catch{,-simplified}.nu.
  - TTY stack: removed shlib/*-tty.sh; replaced by cli/tty-dispatch.sh,
    tty-filter.sh, tty-commands.conf.
  - New domain modules: images/ (golden image lifecycle), workspace/{state,sync}.nu,
    main_provisioning/{bootstrap,cluster-deploy,fip,state}.nu, commands/{state,
    build,integrations/auth,utilities/alias}.nu, platform.nu expanded (+874).
  - Config loader overhaul: loader/core.nu slimmed (-759), cache/core.nu
    refactored (-454), removed legacy loaders/file_loader.nu (-330).
  - Thirteen new provisioning-<domain>.nu top-level modules for bash dispatcher.
  - Tests: test_workspace_state.nu (+351); updates to test_oci_registry,
    test_services.
  - README + CHANGELOG updated.
2026-04-17 04:27:33 +01:00
Jesús Pérez
eb20fec7de
chore: release 1.0.11 - nu script cleanup & refactoring + i18n fluentd
- Documented Fluent-based i18n system with locale detection
  - Bumped version from 1.0.10 to 1.0.11
2026-01-14 02:00:23 +00:00
Jesús Pérez
c62e967ce3
chore: complete KCL to Nickel migration cleanup and setup pre-commit
Clean up 404 KCL references (99.75% complete):
   - Rename kcl_* variables to schema_*/nickel_* (kcl_path→schema_path, etc.)
   - Update functions: parse_kcl_file→parse_nickel_file
   - Update env vars: KCL_MOD_PATH→NICKEL_IMPORT_PATH
   - Fix cli/providers-install: add has_nickel and nickel_version variables
   - Correct import syntax: .nickel.→.ncl.
   - Update 57 files across core, CLI, config, and utilities

   Configure pre-commit hooks:
   - Activate: nushell-check, nickel-typecheck, markdownlint
   - Comment out: Rust hooks (fmt, clippy, test), check-yaml

   Testing:
   - Module discovery: 9 modules (6 providers, 1 taskserv, 2 clusters) 
   - Syntax validation: 15 core files 
   - Pre-commit hooks: all passing 
2026-01-08 20:08:46 +00:00
Jesús Pérez
d8b3cee856
chore: codebase 2025-10-07 10:32:04 +01:00