Jesús Pérez
844f6f9297
refactor(17 files final batch): selective imports — drive to 94% elimination (ADR-025 L2/L3)
...
Final large batch of single-star conversions.
Orchestrator facades (Layer 3, expanded to explicit symbol lists):
config/accessor.nu 18 symbols (bridges accessor/mod)
config/accessor_generated.nu 18 symbols (consumer of accessor)
utils/version.nu 35 symbols (bridges version/mod)
dependencies/mod.nu 7 symbols from resolver.nu
oci_registry/mod.nu 12 multi-word "oci-registry X" subcommands
oci/commands.nu 12 symbols from oci/client.nu
Selective imports (Layer 2):
platform/discovery.nu target.nu [5 symbols]
platform/health.nu target.nu [2 symbols]
platform/connection.nu user/config [get-active-workspace]
vm/preparer.nu vm/detector [check-vm-capability]
vm/backend_libvirt.nu result.nu [7 symbols]
extensions/tests/test_versions.nu versions [5 symbols]
utils/version/loader.nu utils/nickel_processor [ncl-eval ncl-eval-soft]
Dead imports dropped:
platform/credentials.nu user/config
platform/activation.nu target
config/cache/core.nu cache/metadata
config/interpolation/core.nu helpers/environment
utils/version/loader.nu version/core (kept nickel_processor)
Validation: all 17 files match pre-existing baselines (or 0 errors for clean
ones). Pre-existing noise in vm/, dependencies/, oci_registry/, oci/commands
is known transitive — unrelated to this work.
MILESTONE: 94% of star-imports eliminated (370 → 21).
Remaining 21 star-lines in 6 files are intentional exceptions:
- integrations/mod.nu (2 stars, re-exports already-selective children;
acceptable bounded scope)
- cmd/environment.nu (3 stars, contains ~7 undefined function calls —
needs Blocker-1 style cleanup in follow-up commit)
- providers/loader.nu (1 dynamic `use ($entry_point) *` — runtime dispatch)
- vm/cleanup_scheduler.nu (1 in string template — not a real import)
- lib_provisioning/mod.nu (13 stars — root facade; empties in ADR-025 Phase 4)
Refs: ADR-025
2026-04-17 17:08:10 +01:00
Jesús Pérez
2f75500702
refactor(5 test files): selective imports + remove dangling (ADR-025 L2)
...
Five test files, 2 stars each -> selective.
config/encryption_tests.nu:
config/encryption.nu [7 symbols]
kms/client.nu [kms-status]
extensions/tests/test_cache.nu:
extensions/cache.nu DROPPED (dead)
utils/logger.nu REMOVED (file does not exist — dangling)
extensions/tests/test_oci_client.nu:
oci/client.nu [4 symbols]
utils/logger.nu REMOVED (dangling)
extensions/tests/test_discovery.nu:
extensions/discovery.nu [5 symbols]
utils/logger.nu REMOVED (dangling)
config/loader/test.nu:
config/validators.nu [validate-interpolation]
config/interpolators DROPPED (dead)
Pre-existing bug found and removed: 3 test files imported
`../../utils/logger.nu` which doesn't exist. Star-import silenced the
missing-file error; with selective imports it would fail. Cleanest fix:
remove the dangling import (the files never actually used any symbols
from logger.nu — it was a zombie import from a long-deleted file).
Validation: 4 files 0 errors. encryption_tests.nu has 1 pre-existing
error matching baseline.
Refs: ADR-025
2026-04-17 09:18:19 +01:00
Jesús Pérez
894046ef5a
feat(core): three-layer DAG, unified component arch, commands-registry cache, Nushell 0.112.2 migration
...
- DAG architecture: `dag show/validate/export` (nulib/main_provisioning/dag.nu),
config loader (lib_provisioning/config/loader/dag.nu), taskserv dag-executor.
Backed by schemas/lib/dag/*.ncl; orchestrator emits NATS events via
WorkspaceComposition::into_workflow. See ADR-020, ADR-021.
- Unified Component Architecture: components/mod.nu, main_provisioning/
{components,workflow,extensions,ontoref-queries}.nu. Full workflow engine with
topological sort and NATS subject emission. Blocks A-H complete (libre-daoshi).
- Commands-registry: nulib/commands-registry.ncl (Nickel source, 314 lines) +
JSON cache at ~/.cache/provisioning/commands-registry.json rebuilt on source
change. cli/provisioning fast-path alias expansion avoids cold Nu startup.
ADDING_COMMANDS.md documents new-command workflow.
- Platform service manager: service-manager.nu (+573), startup.nu (+611),
service-check.nu (+255); autostart/bootstrap/health/target refactored.
- Nushell 0.112.2 migration: removed all try/catch and bash redirections;
external commands prefixed with ^; type signatures enforced. Driven by
scripts/refactor-try-catch{,-simplified}.nu.
- TTY stack: removed shlib/*-tty.sh; replaced by cli/tty-dispatch.sh,
tty-filter.sh, tty-commands.conf.
- New domain modules: images/ (golden image lifecycle), workspace/{state,sync}.nu,
main_provisioning/{bootstrap,cluster-deploy,fip,state}.nu, commands/{state,
build,integrations/auth,utilities/alias}.nu, platform.nu expanded (+874).
- Config loader overhaul: loader/core.nu slimmed (-759), cache/core.nu
refactored (-454), removed legacy loaders/file_loader.nu (-330).
- Thirteen new provisioning-<domain>.nu top-level modules for bash dispatcher.
- Tests: test_workspace_state.nu (+351); updates to test_oci_registry,
test_services.
- README + CHANGELOG updated.
2026-04-17 04:27:33 +01:00
