Commit graph

3 commits

Author SHA1 Message Date
Jesús Pérez
037acd52eb
refactor(lib): remove dead export-env blocks (ADR-025 blocker 4)
Two export-env blocks in lib_provisioning/ ran at module load time as side
effects of the lib_provisioning/mod.nu star-import chain. ADR-025 empties
that chain; the side effects were never going to fire again and neither has
a remaining reader that depends on them.

1. lib_provisioning/cmd/env.nu
   Former block: called check_env (a pre-flight gate for PROVISIONING_VARS /
   PROVISIONING_WORKSPACE_PATH / PROVISIONING_WK_ENV_PATH existence) and set
   $env.PROVISIONING_DEBUG = false. Nobody imports cmd/env.nu directly; every
   downstream reader of PROVISIONING_DEBUG either sets it explicitly via a
   --debug flag branch or reads it with `?` + default fallback.

2. lib_provisioning/providers/registry.nu
   Former block: $env.PROVIDER_REGISTRY_INITIALIZED = false. The four read
   sites in registry.nu already use `$env.PROVIDER_REGISTRY_INITIALIZED? |
   default false`; the unset state is equivalent to false. Zero behaviour
   change.

Both files now carry a comment explaining the removal so future contributors
understand the history without reading ADR-025.

Refs: ADR-025, .coder/benchmarks/phase2-findings.md export-env decisions
2026-04-17 07:47:19 +01:00
Jesús Pérez
894046ef5a
feat(core): three-layer DAG, unified component arch, commands-registry cache, Nushell 0.112.2 migration
- DAG architecture: `dag show/validate/export` (nulib/main_provisioning/dag.nu),
    config loader (lib_provisioning/config/loader/dag.nu), taskserv dag-executor.
    Backed by schemas/lib/dag/*.ncl; orchestrator emits NATS events via
    WorkspaceComposition::into_workflow. See ADR-020, ADR-021.
  - Unified Component Architecture: components/mod.nu, main_provisioning/
    {components,workflow,extensions,ontoref-queries}.nu. Full workflow engine with
    topological sort and NATS subject emission. Blocks A-H complete (libre-daoshi).
  - Commands-registry: nulib/commands-registry.ncl (Nickel source, 314 lines) +
    JSON cache at ~/.cache/provisioning/commands-registry.json rebuilt on source
    change. cli/provisioning fast-path alias expansion avoids cold Nu startup.
    ADDING_COMMANDS.md documents new-command workflow.
  - Platform service manager: service-manager.nu (+573), startup.nu (+611),
    service-check.nu (+255); autostart/bootstrap/health/target refactored.
  - Nushell 0.112.2 migration: removed all try/catch and bash redirections;
    external commands prefixed with ^; type signatures enforced. Driven by
    scripts/refactor-try-catch{,-simplified}.nu.
  - TTY stack: removed shlib/*-tty.sh; replaced by cli/tty-dispatch.sh,
    tty-filter.sh, tty-commands.conf.
  - New domain modules: images/ (golden image lifecycle), workspace/{state,sync}.nu,
    main_provisioning/{bootstrap,cluster-deploy,fip,state}.nu, commands/{state,
    build,integrations/auth,utilities/alias}.nu, platform.nu expanded (+874).
  - Config loader overhaul: loader/core.nu slimmed (-759), cache/core.nu
    refactored (-454), removed legacy loaders/file_loader.nu (-330).
  - Thirteen new provisioning-<domain>.nu top-level modules for bash dispatcher.
  - Tests: test_workspace_state.nu (+351); updates to test_oci_registry,
    test_services.
  - README + CHANGELOG updated.
2026-04-17 04:27:33 +01:00
Jesús Pérez
d8b3cee856
chore: codebase 2025-10-07 10:32:04 +01:00