Jesús Pérez 2b3e574e3d # Summary

fix: help system integration, build process optimization, and plugin rebuild efficiency

## Detailed Description

This commit addresses critical issues in the help system discoverability, build process robustness, and plugin rebuild efficiency.

### 1. Help System Integration (New Feature)

**Issue**: Version-update module recipes were not discoverable
- Not shown in `just help modules`
- Not referenced in `just help`
- Not included in help navigation system
- Users had to manually run `just --list` to find update commands

**Solution**:
- Added version-update module to all help outputs
- Updated `justfiles/help.just` to document all 30+ version-update recipes
- Created new `just commands` recipe as discoverable alias for `just --list`
- Integrated version-update into help-all workflow

**Impact**:
- Version-update commands now fully discoverable via help system
- Users can find update commands with: `just help modules`, `just help`, `just commands`
- Improved overall help system navigation

**Files Modified**:
- `justfiles/help.just` (+23 lines)
  - Added version-update module to help sections
  - Added to modules list
  - Added to help-all workflow
  - New `commands` recipe showing all recipes by group

### 2. Build Process Fixes (Phase 3: Bin Archives)

#### 2a. Plugin Archive Collection Bug

**Issue**: "No plugins found to package" warning in Phase 3
- Collected 26 plugin binaries but reported 0
- Archive creation skipped because count was wrong

**Root Cause**: `each` command returns null, so `| length` returned 0
```nushell
# ❌ OLD - each returns null
let plugin_count = (ls nu_plugin_*/target/release/nu_plugin_* | each {|p|
    cp $p.name $"($temp_dir)/"
} | length)  # Returns 0!
```

**Solution**: Separated counting from copying with proper filtering
```nushell
# ✅ NEW - count before operations
let plugins_to_copy = (ls nu_plugin_*/target/release/nu_plugin_* | where type == "file")
let plugin_count = ($plugins_to_copy | length)
```

**Impact**:
- Now correctly collects and reports 26 plugins
- Filters out .d dependency files automatically
- Warning eliminated

#### 2b. Tar Archive Path Handling

**Issue**: Tar command failing silently with relative paths in subshell
- `cd $temp_dir` changes context unpredictably
- Relative path `../$archive_name` fails in subshell
- Archive file not created despite exit code 0

**Root Cause**: Shell context and relative path issues in Nushell `do` block

**Solution**: Used `tar -C` with absolute paths instead of `cd`
```nushell
# ❌ OLD - unreliable context switching
do {
    cd $temp_dir
    tar -czf ../$archive_name .
}

# ✅ NEW - absolute paths, no context switching
tar -C $temp_dir -czf $archive_path .
```

**Additional Improvements**:
- Absolute path construction using `pwd | path join`
- Better error diagnostics with exit code and stderr output
- File verification after creation

**Impact**:
- Tar archives now created successfully
- Robust path handling across platforms
- Clear error messages for debugging

#### 2c. File Size Calculation Type Error

**Issue**: Runtime error when calculating archive size
```
Error: The '/' operator does not work on values of type 'list<filesize>'
```

**Root Cause**: `ls` returns list of records, so `.size` was a list
```nushell
# ❌ OLD - returns list<filesize>
(ls $archive_path).size / 1024 / 1024

# ✅ NEW - returns filesize
(ls $archive_path | get 0.size) / 1024 / 1024
```

**Impact**:
- Proper file size calculation in MB
- No more type errors

**Files Modified**:
- `scripts/create_full_distribution.nu` (+58 lines, refactored plugin collection)
  - Fixed plugin counting logic
  - Improved path handling with absolute paths
  - Enhanced error diagnostics

### 3. Plugin Rebuild Optimization

**Issue**: All plugins marked for rebuild even when dependencies unchanged
- Step 4 (`update_all_plugins.nu`) touched all Cargo.toml files at 01:00:32
- Step 5 saw all files as "newer" than binaries
- Marked ALL plugins for rebuild, though cargo only rebuilt changed ones

**Root Cause**: Script always saved files, even when no changes made
```nushell
# ❌ OLD - always saves, touching file timestamp
$updated_content | to toml | save -f $cargo_toml
```

**Solution**: Only save if content actually changed
```nushell
# ✅ NEW - compare before writing
let original_toml = $content | to toml
let new_toml = $updated_content | to toml

if $original_toml != $new_toml {
    $updated_content | to toml | save -f $cargo_toml
}
```

**Impact**:
- Unchanged files preserve original timestamps
- Only plugins with actual dependency changes are rebuilt
- Efficient rebuild process with accurate file modification detection

**Files Modified**:
- `scripts/update_all_plugins.nu` (+12 lines, added content comparison)
  - Only touches files with real changes
  - Preserves timestamps for efficiency
  - Clearer logic and comments

### 4. Documentation

**Files Modified**:
- `CHANGELOG.md` (+56 lines)
  - Added comprehensive 2025-10-19 entry
  - Documented all fixes with root causes
  - Listed files modified and impact summary

## Technical Details

### Nushell Patterns Used

1. **Proper List Handling**:
   - `ls` returns list of records, access with `| get 0.size`
   - Filter with `where type == "file"` to exclude metadata

2. **Absolute Path Construction**:
   - `pwd | append "path" | path join` for cross-platform paths
   - Safer than string concatenation with `/`

3. **Content Comparison**:
   - Compare TOML string representation before saving
   - Preserves file timestamps for efficiency

4. **Error Diagnostics**:
   - Capture `stderr` from commands
   - Report exit codes and error messages separately

## Testing

- [x] Help system shows version-update module
- [x] `just commands` displays all recipes by group
- [x] Phase 3 bin archive creation works
- [x] Plugin collection reports correct count (26)
- [x] Tar archives created successfully
- [x] File size calculated correctly
- [x] Plugin rebuild only touches changed files
- [x] CHANGELOG updated with all changes

## Files Changed

```
38 files changed, 2721 insertions(+), 2548 deletions(-)

Core Changes:
- justfiles/help.just                  (+23)  Help system integration
- scripts/create_full_distribution.nu  (+58)  Build process fixes
- scripts/update_all_plugins.nu        (+12)  Rebuild optimization
- CHANGELOG.md                         (+56)  Documentation

Dependency Updates:
- All plugin Cargo.toml and Cargo.lock files (version consistency)
```

## Breaking Changes

None. These are bug fixes and optimizations that maintain backward compatibility.

## Migration Notes

No migration needed. Improvements are transparent to users.

## Related Issues

- Help system discoverability
- Build process Phase 3 failures
- Unnecessary plugin rebuilds
- Build process reliability

## Checklist

- [x] Changes follow Rust/Nushell idioms
- [x] Code is well-commented
- [x] Error handling is comprehensive
- [x] Documentation is updated
- [x] All changes tested
- [x] No breaking changes introduced

2025-10-19 01:17:13 +01:00

3.9 KiB

Raw Permalink Blame History

Nushell 0.108.0 Update - Complete Guide

Quick Start (Recommended)

Note: If your system nu is broken, this workflow uses the built ./nushell/target/release/nu binary automatically.

Run the complete update in simple steps:

# Step 1: Download Nushell source
./scripts/download_nushell.nu 0.108.0

# Step 2: Build Nushell with all features
cd nushell
cargo build --release --workspace --features "mcp,plugin,sqlite,trash-support,system-clipboard,rustls-tls"
cd ..

# Step 3: Update plugin versions
./scripts/update_all_plugins.nu 0.108.0

# Step 4: Build all plugins
just build

# Step 5: Create distributions
./scripts/create_full_distribution.nu

# Step 6: Validate everything
./scripts/update_all_plugins.nu check
just validate-code

# Step 7: Commit changes
git add -A
git commit -m "chore: update to Nushell 0.108.0"

Using Justfile Commands (Individual Steps)

If you prefer using justfile for individual operations:

# Download source
just download-source 0.108.0

# Analyze available features
just analyze-features

# Build Nushell
just build-nu

# Update plugins
just update-plugins 0.108.0

# Build plugins
just build

# Create distributions
just create-distribution

# Check versions
just check-versions

# Status
just update-status

Full Command Reference

Download & Build

just download-source 0.108.0 - Download from GitHub
just download-latest - Download latest version
just build-nu - Build Nushell binary

Plugin Management

just update-plugins 0.108.0 - Update plugin versions
just sync-plugins - Auto-sync to submodule
just check-versions - Check consistency

Distribution

just create-distribution - Create packages (current platform)
just create-distribution-all - Create all platform packages
just create-bin-archives - Create plugin-only archives
just rebuild-all - Rebuild everything fresh

Analysis & Validation

just analyze-features - Analyze Nushell features
just audit-versions - Check dependency versions
just detect-breaking - Find breaking changes
just validate-code - Validate against binary

Help

just update-help - Quick reference
just update-docs - Documentation paths

Documentation

Quick Start: guides/QUICK_START.md
Complete Guide: guides/COMPLETE_VERSION_UPDATE_GUIDE.md
Version Info: updates/108/NUSHELL_0.108_UPDATE_SUMMARY.md
Migration Guide: updates/108/MIGRATION_0.108.0.md
Automation Details: updates/108/NUSHELL_UPDATE_AUTOMATION.md

Status

✅ All automation scripts created and tested ✅ Justfile integration complete (28 recipes) ✅ Nushell 0.108.0 successfully built ✅ Documentation comprehensive ✅ Ready for production use

Notes

Nushell 0.108.0 includes MCP (Model Context Protocol) support
All system plugins built: formats, inc, gstat, query, polars, custom_values, example, stress_internals
Build time: ~3 minutes on recent hardware
Updates are resource-intensive; run steps individually for best stability

⚠️ CRITICAL: System Nu Binary Issue (RESOLVED)

Problem: If your system nu binary (in PATH) gets killed with signal 9, the automation scripts will fail.

Root Cause: The system nu binary at /Users/jesusperezlorenzo/.local/bin/nu may be corrupted or have compatibility issues.

Solution: The automation scripts have been updated to use the newly built ./nushell/target/release/nu binary instead of the system one.

Fix Your System Nu (recommended after update):

# Backup current system nu
mv ~/.local/bin/nu ~/.local/bin/nu.broken

# Copy working 0.108.0 binary
cp ./nushell/target/release/nu ~/.local/bin/nu

# Verify it works
nu --version  # Should show 0.108.0 without being killed

Verification:

# Test if your system nu is broken
nu --version
# If this gets "Killed: 9", your system nu is broken

# Test the built nu (should always work)
./nushell/target/release/nu --version
# Should show 0.108.0 successfully

3.9 KiB Raw Permalink Blame History